Merge branch '31358_decrease_perceived_complexity_threshold_step2' into 'master'
Decrease Perceived Complexity threshold to 15 See merge request !14160
This commit is contained in:
commit
61b596a681
|
@ -665,7 +665,7 @@ Metrics/ParameterLists:
|
|||
# A complexity metric geared towards measuring complexity for a human reader.
|
||||
Metrics/PerceivedComplexity:
|
||||
Enabled: true
|
||||
Max: 17
|
||||
Max: 15
|
||||
|
||||
# Lint ########################################################################
|
||||
|
||||
|
|
|
@ -241,13 +241,7 @@ class Event < ActiveRecord::Base
|
|||
|
||||
def action_name
|
||||
if push?
|
||||
if new_ref?
|
||||
"pushed new"
|
||||
elsif rm_ref?
|
||||
"deleted"
|
||||
else
|
||||
"pushed to"
|
||||
end
|
||||
push_action_name
|
||||
elsif closed?
|
||||
"closed"
|
||||
elsif merged?
|
||||
|
@ -263,11 +257,7 @@ class Event < ActiveRecord::Base
|
|||
elsif commented?
|
||||
"commented on"
|
||||
elsif created_project?
|
||||
if project.external_import?
|
||||
"imported"
|
||||
else
|
||||
"created"
|
||||
end
|
||||
created_project_action_name
|
||||
else
|
||||
"opened"
|
||||
end
|
||||
|
@ -360,6 +350,24 @@ class Event < ActiveRecord::Base
|
|||
|
||||
private
|
||||
|
||||
def push_action_name
|
||||
if new_ref?
|
||||
"pushed new"
|
||||
elsif rm_ref?
|
||||
"deleted"
|
||||
else
|
||||
"pushed to"
|
||||
end
|
||||
end
|
||||
|
||||
def created_project_action_name
|
||||
if project.external_import?
|
||||
"imported"
|
||||
else
|
||||
"created"
|
||||
end
|
||||
end
|
||||
|
||||
def recent_update?
|
||||
project.last_activity_at > RESET_PROJECT_ACTIVITY_INTERVAL.ago
|
||||
end
|
||||
|
|
|
@ -0,0 +1,5 @@
|
|||
---
|
||||
title: Decrease Perceived Complexity threshold to 15
|
||||
merge_request: 14160
|
||||
author: Maxim Rydkin
|
||||
type: other
|
Loading…
Reference in New Issue