Be more specific since it's not needed to be generic now,

feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6084#note_14995016
This commit is contained in:
Lin Jen-Shin 2016-09-06 19:57:51 +08:00
parent 7351c269de
commit 61bc90af0e
1 changed files with 5 additions and 3 deletions

View File

@ -91,12 +91,14 @@ module Gitlab
builds = pipeline.builds.latest.
where(status: status).where.not(started_at: nil).order(:started_at)
from_builds(builds, :started_at, :finished_at)
from_builds(builds)
end
def from_builds(builds, from, to, now = Time.now)
def from_builds(builds)
now = Time.now
periods = builds.map do |b|
Period.new(b.public_send(from) || now, b.public_send(to) || now)
Period.new(b.started_at, b.finished_at || now)
end
from_periods(periods)