From 61ca90e0b462bfe69e0b400dfe403bd95281b90f Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 13 Oct 2022 09:37:59 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/review-apps/main.gitlab-ci.yml | 5 +- .../graphql_shared/issuable_client.js | 40 - .../components/user_popover/user_popover.vue | 3 +- .../components/work_item_detail.vue | 2 +- .../components/work_item_labels.vue | 101 +- .../javascripts/work_items/constants.js | 3 + .../work_items/graphql/typedefs.graphql | 19 - .../graphql/work_item.query.graphql | 10 - .../work_item_widgets.fragment.graphql | 11 + app/controllers/users_controller.rb | 3 +- .../protected_branch/merge_access_level.rb | 2 + .../protected_branch/push_access_level.rb | 2 + app/models/user.rb | 3 +- app/models/users/user_follow_user.rb | 15 + .../clusters/applications/destroy_service.rb | 23 - .../applications/uninstall_service.rb | 29 - .../settings/access_tokens/index.html.haml | 1 + .../shared/access_tokens/_form.html.haml | 3 +- .../shared/tokens/_scopes_form.html.haml | 3 +- .../clusters/applications/uninstall_worker.rb | 6 +- config/locales/doorkeeper.en.yml | 12 +- db/docs/push_rules.yml | 2 +- ...nt_settings_on_project_id_and_sla_timer.rb | 17 + db/schema_migrations/20221011162637 | 1 + db/structure.sql | 2 + doc/administration/system_hooks.md | 2 +- doc/api/api_resources.md | 2 +- doc/api/graphql/getting_started.md | 2 +- doc/api/graphql/index.md | 2 +- doc/api/graphql/removed_items.md | 2 +- doc/api/index.md | 2 +- doc/api/integrations.md | 2 +- doc/api/openapi/openapi_interactive.md | 2 +- doc/api/saml.md | 78 ++ doc/api/scim.md | 243 +---- doc/api/system_hooks.md | 2 +- doc/development/fe_guide/view_component.md | 2 +- doc/development/graphql_guide/graphql_pro.md | 2 +- doc/development/graphql_guide/index.md | 2 +- doc/development/graphql_guide/monitoring.md | 2 +- doc/development/graphql_guide/pagination.md | 2 +- doc/development/integrations/index.md | 2 +- doc/development/integrations/jenkins.md | 2 +- doc/development/integrations/jira_connect.md | 2 +- doc/development/internal_api/index.md | 250 +++++ doc/integration/datadog.md | 2 +- doc/integration/external-issue-tracker.md | 2 +- .../gmail_action_buttons_for_gitlab.md | 2 +- doc/integration/index.md | 2 +- doc/integration/jenkins.md | 2 +- doc/integration/jenkins_deprecated.md | 2 +- doc/integration/jira/configure.md | 2 +- doc/integration/jira/connect-app.md | 2 +- doc/integration/jira/development_panel.md | 2 +- doc/integration/jira/dvcs.md | 2 +- doc/integration/jira/index.md | 2 +- doc/integration/jira/issues.md | 2 +- .../jira/jira_cloud_configuration.md | 2 +- .../jira/jira_server_configuration.md | 2 +- doc/integration/slash_commands.md | 2 +- doc/integration/trello_power_up.md | 2 +- doc/subscriptions/self_managed/index.md | 2 +- .../project_integration_management.md | 2 +- doc/user/group/saml_sso/scim_setup.md | 4 +- .../group/saml_sso/troubleshooting_scim.md | 10 +- .../group/settings/group_access_tokens.md | 8 +- doc/user/profile/index.md | 3 + doc/user/profile/personal_access_tokens.md | 16 +- doc/user/project/deploy_tokens/index.md | 10 +- doc/user/project/import/github.md | 2 +- doc/user/project/integrations/asana.md | 2 +- doc/user/project/integrations/bamboo.md | 2 +- doc/user/project/integrations/bugzilla.md | 2 +- .../integrations/custom_issue_tracker.md | 2 +- .../integrations/discord_notifications.md | 2 +- .../project/integrations/emails_on_push.md | 2 +- doc/user/project/integrations/ewm.md | 2 +- doc/user/project/integrations/github.md | 2 +- .../integrations/gitlab_slack_application.md | 2 +- .../project/integrations/hangouts_chat.md | 2 +- doc/user/project/integrations/harbor.md | 2 +- doc/user/project/integrations/index.md | 2 +- doc/user/project/integrations/irker.md | 2 +- doc/user/project/integrations/mattermost.md | 2 +- .../integrations/mattermost_slash_commands.md | 2 +- .../project/integrations/microsoft_teams.md | 2 +- doc/user/project/integrations/mock_ci.md | 2 +- .../integrations/pipeline_status_emails.md | 2 +- .../project/integrations/pivotal_tracker.md | 2 +- doc/user/project/integrations/pumble.md | 2 +- doc/user/project/integrations/redmine.md | 2 +- doc/user/project/integrations/servicenow.md | 2 +- doc/user/project/integrations/shimo.md | 2 +- doc/user/project/integrations/slack.md | 2 +- .../integrations/slack_slash_commands.md | 2 +- .../project/integrations/unify_circuit.md | 2 +- doc/user/project/integrations/webex_teams.md | 2 +- .../project/integrations/webhook_events.md | 2 +- doc/user/project/integrations/webhooks.md | 2 +- doc/user/project/integrations/youtrack.md | 2 +- doc/user/project/integrations/zentao.md | 2 +- doc/user/project/pages/public_folder.md | 6 +- .../project/settings/project_access_tokens.md | 8 +- lib/api/users.rb | 5 +- .../security/concerns/deprecated_syntax.rb | 36 - lib/gitlab/ci/parsers/security/sast.rb | 4 - .../ci/parsers/security/secret_detection.rb | 4 - .../importer/note_attachments_importer.rb | 33 +- .../importer/protected_branch_importer.rb | 73 +- .../github_import/markdown/attachment.rb | 86 ++ lib/gitlab/github_import/markdown_text.rb | 50 +- .../representation/protected_branch.rb | 8 +- lib/gitlab/i18n.rb | 22 +- locale/gitlab.pot | 6 + scripts/review_apps/review-apps.sh | 19 +- spec/factories/ci/job_artifacts.rb | 10 - .../deprecated/gl-sast-report.json | 964 ------------------ .../user_popover/user_popover_spec.js | 54 +- .../components/work_item_detail_spec.js | 22 +- .../components/work_item_labels_spec.js | 76 +- spec/frontend/work_items/mock_data.js | 50 +- .../gitlab/ci/parsers/security/sast_spec.rb | 53 - .../note_attachments_importer_spec.rb | 31 +- .../protected_branch_importer_spec.rb | 115 ++- .../protected_branches_importer_spec.rb | 6 + .../github_import/markdown/attachment_spec.rb | 93 ++ .../github_import/markdown_text_spec.rb | 37 +- .../representation/protected_branch_spec.rb | 13 +- spec/models/user_spec.rb | 28 + spec/requests/api/users_spec.rb | 11 + spec/requests/users_controller_spec.rb | 20 + .../applications/destroy_service_spec.rb | 63 -- .../applications/uninstall_service_spec.rb | 77 -- 133 files changed, 1302 insertions(+), 1855 deletions(-) delete mode 100644 app/services/clusters/applications/destroy_service.rb delete mode 100644 app/services/clusters/applications/uninstall_service.rb create mode 100644 db/migrate/20221011162637_add_partial_index_project_incident_management_settings_on_project_id_and_sla_timer.rb create mode 100644 db/schema_migrations/20221011162637 create mode 100644 doc/api/saml.md delete mode 100644 lib/gitlab/ci/parsers/security/concerns/deprecated_syntax.rb create mode 100644 lib/gitlab/github_import/markdown/attachment.rb delete mode 100644 spec/fixtures/security_reports/deprecated/gl-sast-report.json create mode 100644 spec/lib/gitlab/github_import/markdown/attachment_spec.rb delete mode 100644 spec/services/clusters/applications/destroy_service_spec.rb delete mode 100644 spec/services/clusters/applications/uninstall_service_spec.rb diff --git a/.gitlab/ci/review-apps/main.gitlab-ci.yml b/.gitlab/ci/review-apps/main.gitlab-ci.yml index 4c0a3579c92..201c32741f9 100644 --- a/.gitlab/ci/review-apps/main.gitlab-ci.yml +++ b/.gitlab/ci/review-apps/main.gitlab-ci.yml @@ -101,6 +101,10 @@ review-deploy: - .review:rules:review-deploy stage: deploy needs: ["review-build-cng"] + cache: + key: "review-deploy-dependencies-charts-${GITLAB_HELM_CHART_REF}-v1" + paths: + - "gitlab-${GITLAB_HELM_CHART_REF}" before_script: - export GITLAB_SHELL_VERSION=$( { - if (input.labels) { - const labelsWidget = draftData.workItem.mockWidgets.find( - (widget) => widget.type === WIDGET_TYPE_LABELS, - ); - labelsWidget.nodes = [...input.labels]; - } - }); - - cache.writeQuery({ - query: workItemQuery, - variables: { id: input.id }, - data, - }); - }, }, }; diff --git a/app/assets/javascripts/vue_shared/components/user_popover/user_popover.vue b/app/assets/javascripts/vue_shared/components/user_popover/user_popover.vue index 6151d2ff85c..80c1fcbacfa 100644 --- a/app/assets/javascripts/vue_shared/components/user_popover/user_popover.vue +++ b/app/assets/javascripts/vue_shared/components/user_popover/user_popover.vue @@ -141,8 +141,9 @@ export default { await followUser(this.user.id); this.$emit('follow'); } catch (error) { + const message = error.response?.data?.message || I18N_ERROR_FOLLOW; createAlert({ - message: I18N_ERROR_FOLLOW, + message, error, captureError: true, }); diff --git a/app/assets/javascripts/work_items/components/work_item_detail.vue b/app/assets/javascripts/work_items/components/work_item_detail.vue index 99b1a73b983..3255c7e5e4d 100644 --- a/app/assets/javascripts/work_items/components/work_item_detail.vue +++ b/app/assets/javascripts/work_items/components/work_item_detail.vue @@ -177,7 +177,7 @@ export default { return this.workItem?.widgets?.find((widget) => widget.type === WIDGET_TYPE_ASSIGNEES); }, workItemLabels() { - return this.workItem?.mockWidgets?.find((widget) => widget.type === WIDGET_TYPE_LABELS); + return this.workItem?.widgets?.find((widget) => widget.type === WIDGET_TYPE_LABELS); }, workItemDueDate() { return this.workItem?.widgets?.find( diff --git a/app/assets/javascripts/work_items/components/work_item_labels.vue b/app/assets/javascripts/work_items/components/work_item_labels.vue index a06c90468de..9a36ddc0204 100644 --- a/app/assets/javascripts/work_items/components/work_item_labels.vue +++ b/app/assets/javascripts/work_items/components/work_item_labels.vue @@ -1,16 +1,21 @@