reverting more MR ajax files, will appear in different commit

app/views/projects/merge_requests/widget/_open.html.haml

@@ -1,22 +1,23 @@
-.mr-state-widget.mr-state-widget-opened{class: merge_request_widget_visibility(@merge_request, "opened","reopened")}
+.mr-state-widget
   = render 'projects/merge_requests/widget/heading'
-  .mr-widget-body.merge-request-archived{class: ("hidden" unless @project.archived?)}
+  .mr-widget-body
+    - if @project.archived?
       = render 'projects/merge_requests/widget/open/archived'
-  .mr-widget-body.merge-request-blank{class: ("hidden" unless @merge_request.commits.blank?)}
+    - elsif @merge_request.commits.blank?
       = render 'projects/merge_requests/widget/open/nothing'
-  .mr-widget-body.merge-request-branch-missing{class: ("hidden" unless @merge_request.branch_missing?)}
+    - elsif @merge_request.branch_missing?
       = render 'projects/merge_requests/widget/open/missing_branch'
-  .mr-widget-body.merge-request-unchecked{class: ("hidden" unless @merge_request.unchecked?)}
+    - elsif @merge_request.unchecked?
       = render 'projects/merge_requests/widget/open/check'
-  .mr-widget-body.merge-request-cannot-be-merged{class: ("hidden" unless @merge_request.cannot_be_merged?)}
+    - elsif @merge_request.cannot_be_merged?
       = render 'projects/merge_requests/widget/open/conflicts'
-  .mr-widget-body.merge-request-work-in-progress{class: ("hidden" unless @merge_request.work_in_progress?)}
+    - elsif @merge_request.work_in_progress?
       = render 'projects/merge_requests/widget/open/wip'
-  .mr-widget-body.merge-request-merge-when-build-succeeds{class: ("hidden" unless @merge_request.merge_when_build_succeeds?)}
+    - elsif @merge_request.merge_when_build_succeeds?
       = render 'projects/merge_requests/widget/open/merge_when_build_succeeds'
-  .mr-widget-body.not-allowed{class: ("hidden" if @merge_request.can_be_merged_by?(current_user))}
+    - elsif !@merge_request.can_be_merged_by?(current_user)
       = render 'projects/merge_requests/widget/open/not_allowed'
-  .mr-widget-body.merge-request-archived.can-be-merged{class: ("hidden" unless @merge_request.can_be_merged?)}
+    - elsif @merge_request.can_be_merged?
       = render 'projects/merge_requests/widget/open/accept'
 
   - if @closes_issues.present?

app/views/projects/merge_requests/widget/_show.html.haml

@@ -1,13 +1,17 @@
-= render 'projects/merge_requests/widget/open'
-= render 'projects/merge_requests/widget/merged'
-= render 'projects/merge_requests/widget/closed'
-= render 'projects/merge_requests/widget/locked'
+- if @merge_request.open?
+  = render 'projects/merge_requests/widget/open'
+- elsif @merge_request.merged?
+  = render 'projects/merge_requests/widget/merged'
+- elsif @merge_request.closed?
+  = render 'projects/merge_requests/widget/closed'
+- elsif @merge_request.locked?
+  = render 'projects/merge_requests/widget/locked'
 
 :javascript
   var merge_request_widget;
 
   merge_request_widget = new MergeRequestWidget({
-    url_to_automerge_check: "#{merge_check_namespace_project_merge_request_path(@project.namespace, @project, @merge_request, format: :json)}",
+    url_to_automerge_check: "#{merge_check_namespace_project_merge_request_path(@project.namespace, @project, @merge_request)}",
     check_enable: #{@merge_request.unchecked? ? "true" : "false"},
     url_to_ci_check: "#{ci_status_namespace_project_merge_request_path(@project.namespace, @project, @merge_request)}",
     ci_enable: #{@project.ci_service ? "true" : "false"},

spec/javascripts/fixtures/merge_requests_show.html.haml

@@ -1,14 +1,4 @@
-:css
-  .hidden { display: none !important }
-
-.flash-container
-  .flash-alert
-  .flash-notice
-
-.status-box.status-box-open Open
-.status-box.status-box-closed.hidden Closed
-%a.btn-close{"href" => "http://gitlab.com/merge_requests/6/close"} Close
-%a.btn-reopen.hidden{"href" => "http://gitlab.com/merge_requests/6/reopen"} Reopen
+%a.btn-close
 
 .detail-page-description
   .description.js-task-list-container

spec/javascripts/merge_request_spec.js.coffee

@@ -21,91 +21,3 @@ describe 'MergeRequest', ->
         expect(req.data.merge_request.description).not.toBe(null)
 
       $('.js-task-list-field').trigger('tasklist:changed')
-
-  describe 'reopen/close merge request', ->
-    fixture.preload('merge_requests_show.html')
-    beforeEach ->
-      fixture.load('merge_requests_show.html')
-      @merge_request = new MergeRequest({})
-    it 'closes a merge request', ->
-      $.ajax = (obj) ->
-        expect(obj.type).toBe('PUT')
-        expect(obj.url).toBe('http://gitlab.com/merge_requests/6/close')
-        obj.success saved:true
-
-      $btnClose = $('a.btn-close')
-      $btnReopen = $('a.btn-reopen')
-      expect($btnReopen).toBeHidden()
-      expect($btnClose.text()).toBe('Close')
-      expect(typeof $btnClose.prop('disabled')).toBe('undefined')
-
-      $btnClose.trigger('click')
-
-      expect($btnReopen).toBeVisible()
-
-      expect($btnClose).toBeHidden()
-      expect($('div.status-box-closed')).toBeVisible()
-      expect($('div.status-box-open')).toBeHidden()
-
-    it 'fails to close a merge request with success:false', ->
-
-      $.ajax = (obj) ->
-        expect(obj.type).toBe('PUT')
-        expect(obj.url).toBe('http://goesnowhere.nothing/whereami')
-        obj.success saved:false
-
-      $btnClose = $('a.btn-close')
-      $btnReopen = $('a.btn-reopen')
-      $btnClose.attr('href','http://goesnowhere.nothing/whereami')
-      expect($btnReopen).toBeHidden()
-      expect($btnClose.text()).toBe('Close')
-      expect(typeof $btnClose.prop('disabled')).toBe('undefined')
-
-      $btnClose.trigger('click')
-
-      expect($btnReopen).toBeHidden()
-      expect($btnClose).toBeVisible()
-      expect($('div.status-box-closed')).toBeHidden()
-      expect($('div.status-box-open')).toBeVisible()
-      expect($('div.flash-alert')).toBeVisible()
-      expect($('div.flash-alert').text()).toBe('Unable to update this merge request at this time.')
-
-    it 'fails to closes an issue with HTTP error', ->
-
-      $.ajax = (obj) ->
-        expect(obj.type).toBe('PUT')
-        expect(obj.url).toBe('http://goesnowhere.nothing/whereami')
-        obj.error()
-      
-      $btnClose = $('a.btn-close')
-      $btnReopen = $('a.btn-reopen')
-      $btnClose.attr('href','http://goesnowhere.nothing/whereami')
-      expect($btnReopen).toBeHidden()
-      expect($btnClose.text()).toBe('Close')
-      expect(typeof $btnClose.prop('disabled')).toBe('undefined')
-
-      $btnClose.trigger('click')
-      
-      expect($btnReopen).toBeHidden()
-      expect($btnClose).toBeVisible()
-      expect($('div.status-box-closed')).toBeHidden()
-      expect($('div.status-box-open')).toBeVisible()
-      expect($('div.flash-alert')).toBeVisible()
-      expect($('div.flash-alert').text()).toBe('Unable to update this merge request at this time.')    
-    
-    it 'reopens a merge request', ->
-      $.ajax = (obj) ->
-        expect(obj.type).toBe('PUT')
-        expect(obj.url).toBe('http://gitlab.com/merge_requests/6/reopen')
-        obj.success saved: true
-
-      $btnClose = $('a.btn-close')
-      $btnReopen = $('a.btn-reopen')
-      expect($btnReopen.text()).toBe('Reopen')
-
-      $btnReopen.trigger('click')
-
-      expect($btnReopen).toBeHidden()
-      expect($btnClose).toBeVisible()
-      expect($('div.status-box-open')).toBeVisible()
-      expect($('div.status-box-closed')).toBeHidden()