kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Improve language

Browse source
This commit is contained in:
Zeger-Jan van de Weg 2019-02-18 07:14:16 +00:00
parent 341556816c
commit 633cb37e28
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
doc/development/code_review.md
View file

@ -134,10 +134,11 @@ as the maintainer to ultimately approve and merge it.
Try to review in a timely manner; doing so allows everyone involved in the merge
request to iterate faster as the context is fresh in memory. Further, this
improves contributors' experiences significantly. Provided full availability;
reviewing within two work days should be the aim. If you don't think you'll be
able to review a merge request within that time, let the author know as soon as
possible.
improves contributors' experiences significantly. Reviewers should aim to review
within two working days from the date they were assigned the merge request. If
you don't think you'll be able to review a merge request within that time, let
the author know as soon as possible. When the author of the merge request has not
heard anything after two days, a new reviewer should be assigned.
Maintainers should check before merging if the merge request is approved by the
required approvers.