Merge branch '36906_Reordering_issues_to_the_bottom' into 'master'

Fixing re-ordering of an issue when dragging it to the bottom a long issue list in the board

Closes #36906

See merge request gitlab-org/gitlab-ce!16250
This commit is contained in:
Phil Hughes 2018-01-09 09:25:42 +00:00
commit 639cfdc221
3 changed files with 18 additions and 1 deletions

View File

@ -187,7 +187,7 @@ export default {
<li
class="board-list-count text-center"
v-if="showCount"
data-id="-1">
data-issue-id="-1">
<loading-icon
v-show="list.loadingMore"

View File

@ -0,0 +1,5 @@
---
title: "Issue board: fix for dragging an issue to the very bottom in long lists"
merge_request: 16250
author: David Kuri
type: fixed

View File

@ -154,6 +154,18 @@ describe('Board list component', () => {
});
});
it('sets data attribute with invalid id', (done) => {
component.showCount = true;
Vue.nextTick(() => {
expect(
component.$el.querySelector('.board-list-count').getAttribute('data-issue-id'),
).toBe('-1');
done();
});
});
it('shows how many more issues to load', (done) => {
component.showCount = true;
component.list.issuesSize = 20;