kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Merge branch 'label-length-validation' into 'master'

Browse source 
Validate label's title length

See merge request !5767
This commit is contained in:
Rémy Coutable 2017-01-09 20:50:57 +00:00
commit 6524ec5dee
3 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/models/label.rb
View file

@ -26,6 +26,7 @@ class Label < ActiveRecord::Base
# Don't allow ',' for label titles # Don't allow ',' for label titles
validates :title, presence: true, format: { with: /\A[^,]+\z/ } validates :title, presence: true, format: { with: /\A[^,]+\z/ }
validates :title, uniqueness: { scope: [:group_id, :project_id] } validates :title, uniqueness: { scope: [:group_id, :project_id] }
validates :title, length: { maximum: 255 }
default_scope { order(title: :asc) } default_scope { order(title: :asc) }

4
changelogs/unreleased/validate-title-length.yml Normal file
View file

@ -0,0 +1,4 @@
---
title: "Validate label's title length"
merge_request: 5767
author: Tomáš Kukrál

2
spec/models/label_spec.rb
View file

@ -31,12 +31,14 @@ describe Label, models: true do
it 'validates title' do it 'validates title' do
is_expected.not_to allow_value('G,ITLAB').for(:title) is_expected.not_to allow_value('G,ITLAB').for(:title)
is_expected.not_to allow_value('').for(:title) is_expected.not_to allow_value('').for(:title)
is_expected.not_to allow_value('s' * 256).for(:title)
is_expected.to allow_value('GITLAB').for(:title) is_expected.to allow_value('GITLAB').for(:title)
is_expected.to allow_value('gitlab').for(:title) is_expected.to allow_value('gitlab').for(:title)
is_expected.to allow_value('G?ITLAB').for(:title) is_expected.to allow_value('G?ITLAB').for(:title)
is_expected.to allow_value('G&ITLAB').for(:title) is_expected.to allow_value('G&ITLAB').for(:title)
is_expected.to allow_value("customer's request").for(:title) is_expected.to allow_value("customer's request").for(:title)
is_expected.to allow_value('s' * 255).for(:title)
end end
end end