diff --git a/.rubocop.yml b/.rubocop.yml index ccc5967ebed..76e8e1b8e65 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -571,3 +571,9 @@ Gitlab/RailsLogger: Exclude: - 'spec/**/*.rb' - 'ee/spec/**/*.rb' + +# WIP See https://gitlab.com/gitlab-org/gitlab/-/issues/267606 +FactoryBot/InlineAssociation: + Include: + - 'spec/factories/**/*.rb' + - 'ee/spec/factories/**/*.rb' diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 7ac92aadeb7..ba6efce0e25 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1278,3 +1278,44 @@ Graphql/IDType: - 'app/graphql/resolvers/snippets_resolver.rb' - 'app/graphql/resolvers/user_merge_requests_resolver.rb' - 'app/graphql/resolvers/user_resolver.rb' + +# Offense count: 86 +# Cop supports --auto-correct. +FactoryBot/InlineAssociation: + Exclude: + - 'ee/spec/factories/analytics/cycle_analytics/group_stages.rb' + - 'ee/spec/factories/ci/reports/security/findings.rb' + - 'ee/spec/factories/ci/reports/security/reports.rb' + - 'ee/spec/factories/geo/event_log.rb' + - 'ee/spec/factories/groups.rb' + - 'ee/spec/factories/merge_request_blocks.rb' + - 'ee/spec/factories/resource_iteration_event.rb' + - 'ee/spec/factories/resource_weight_events.rb' + - 'ee/spec/factories/vulnerabilities/feedback.rb' + - 'spec/factories/atlassian_identities.rb' + - 'spec/factories/audit_events.rb' + - 'spec/factories/design_management/design_at_version.rb' + - 'spec/factories/design_management/designs.rb' + - 'spec/factories/design_management/versions.rb' + - 'spec/factories/events.rb' + - 'spec/factories/git_wiki_commit_details.rb' + - 'spec/factories/gitaly/commit.rb' + - 'spec/factories/go_module_commits.rb' + - 'spec/factories/go_module_versions.rb' + - 'spec/factories/go_modules.rb' + - 'spec/factories/group_group_links.rb' + - 'spec/factories/import_export_uploads.rb' + - 'spec/factories/merge_requests.rb' + - 'spec/factories/notes.rb' + - 'spec/factories/packages.rb' + - 'spec/factories/packages/package_file.rb' + - 'spec/factories/prometheus_alert.rb' + - 'spec/factories/resource_label_events.rb' + - 'spec/factories/resource_milestone_event.rb' + - 'spec/factories/resource_state_event.rb' + - 'spec/factories/sent_notifications.rb' + - 'spec/factories/serverless/domain.rb' + - 'spec/factories/serverless/domain_cluster.rb' + - 'spec/factories/terraform/state.rb' + - 'spec/factories/uploads.rb' + - 'spec/factories/wiki_pages.rb' diff --git a/app/assets/javascripts/boards/models/list.js b/app/assets/javascripts/boards/models/list.js index 2f6caffbf84..09f5d5b4dd8 100644 --- a/app/assets/javascripts/boards/models/list.js +++ b/app/assets/javascripts/boards/models/list.js @@ -1,4 +1,4 @@ -/* eslint-disable no-underscore-dangle, class-methods-use-this */ +/* eslint-disable class-methods-use-this */ import { __ } from '~/locale'; import ListLabel from './label'; import ListAssignee from './assignee'; @@ -34,7 +34,6 @@ const TYPES = { class List { constructor(obj) { this.id = obj.id; - this._uid = this.guid(); this.position = obj.position; this.title = (obj.list_type || obj.listType) === 'backlog' ? __('Open') : obj.title; this.type = obj.list_type || obj.listType; diff --git a/app/assets/javascripts/boards/stores/actions.js b/app/assets/javascripts/boards/stores/actions.js index bd1bf17b0c7..1fed1228106 100644 --- a/app/assets/javascripts/boards/stores/actions.js +++ b/app/assets/javascripts/boards/stores/actions.js @@ -1,5 +1,7 @@ import Cookies from 'js-cookie'; import { pick } from 'lodash'; + +import boardListsQuery from 'ee_else_ce/boards/queries/board_lists.query.graphql'; import { __ } from '~/locale'; import { parseBoolean } from '~/lib/utils/common_utils'; import createGqClient, { fetchPolicies } from '~/lib/graphql'; @@ -15,7 +17,6 @@ import { import boardStore from '~/boards/stores/boards_store'; import listsIssuesQuery from '../queries/lists_issues.query.graphql'; -import boardListsQuery from '../queries/board_lists.query.graphql'; import createBoardListMutation from '../queries/board_list_create.mutation.graphql'; import updateBoardListMutation from '../queries/board_list_update.mutation.graphql'; import issueMoveListMutation from '../queries/issue_move_list.mutation.graphql'; @@ -76,10 +77,10 @@ export default { variables, }) .then(({ data }) => { - const { lists } = data[boardType]?.board; + const { lists, hideBacklogList } = data[boardType]?.board; commit(types.RECEIVE_BOARD_LISTS_SUCCESS, formatBoardLists(lists)); - // Backlog list needs to be created if it doesn't exist - if (!lists.nodes.find(l => l.listType === ListType.backlog)) { + // Backlog list needs to be created if it doesn't exist and it's not hidden + if (!lists.nodes.find(l => l.listType === ListType.backlog) && !hideBacklogList) { dispatch('createList', { backlog: true }); } dispatch('showWelcomeList'); diff --git a/app/assets/javascripts/ide/components/file_templates/bar.vue b/app/assets/javascripts/ide/components/file_templates/bar.vue index b6a57d1b6e6..88dca2f0556 100644 --- a/app/assets/javascripts/ide/components/file_templates/bar.vue +++ b/app/assets/javascripts/ide/components/file_templates/bar.vue @@ -1,10 +1,12 @@