kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Reduce cognitivty complexity more

This commit is contained in:
syasonik 2019-04-18 15:41:34 +08:00
parent 1edbf97e25
commit 655fae4242
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
app/controllers/projects/environments_controller.rb
View File

@ -164,10 +164,7 @@ class Projects::EnvironmentsController < Projects::ApplicationController
format.json do
result = Gitlab::MetricsDashboard::Service.new(@project, @current_user, environment: environment).get_dashboard
ok_status = :ok if result[:status] == :success
status = ok_status || result[:http_status] || :bad_request
render status: status, json: result
render_metrics_dashboard_response(result)
end
end
end
@ -212,6 +209,13 @@ class Projects::EnvironmentsController < Projects::ApplicationController
params.require([:start, :end])
end
def render_metrics_dashboard_response(result)
ok_status = :ok if result[:status] == :success
status = ok_status || result[:http_status] || :bad_request
render status: status, json: result
end
def search_environment_names
return [] unless params[:query]