Reduce cognitivty complexity more
This commit is contained in:
parent
1edbf97e25
commit
655fae4242
|
@ -164,10 +164,7 @@ class Projects::EnvironmentsController < Projects::ApplicationController
|
||||||
format.json do
|
format.json do
|
||||||
result = Gitlab::MetricsDashboard::Service.new(@project, @current_user, environment: environment).get_dashboard
|
result = Gitlab::MetricsDashboard::Service.new(@project, @current_user, environment: environment).get_dashboard
|
||||||
|
|
||||||
ok_status = :ok if result[:status] == :success
|
render_metrics_dashboard_response(result)
|
||||||
status = ok_status || result[:http_status] || :bad_request
|
|
||||||
|
|
||||||
render status: status, json: result
|
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
@ -212,6 +209,13 @@ class Projects::EnvironmentsController < Projects::ApplicationController
|
||||||
params.require([:start, :end])
|
params.require([:start, :end])
|
||||||
end
|
end
|
||||||
|
|
||||||
|
def render_metrics_dashboard_response(result)
|
||||||
|
ok_status = :ok if result[:status] == :success
|
||||||
|
status = ok_status || result[:http_status] || :bad_request
|
||||||
|
|
||||||
|
render status: status, json: result
|
||||||
|
end
|
||||||
|
|
||||||
def search_environment_names
|
def search_environment_names
|
||||||
return [] unless params[:query]
|
return [] unless params[:query]
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue