From 66629d156e2420269ed53eff3dca0912cfe848e2 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 1 Dec 2021 15:13:55 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../boards/components/board_card_inner.vue | 2 +- .../components/triggers_list.vue | 2 +- .../components/environment_item.vue | 2 +- .../components/error_details.vue | 2 +- .../components/issues_list_app.vue | 13 ++- .../javascripts/jobs/components/sidebar.vue | 2 +- .../components/header/validation_segment.vue | 2 +- .../components/pipeline_graph/job_pill.vue | 2 +- .../components/pipeline_graph/stage_name.vue | 2 +- .../pipelines/charts/components/app.vue | 25 ++++- .../components/blob_viewers/index.js | 5 + .../components/blob_viewers/pdf_viewer.vue | 16 +++ .../admin_runners/admin_runners_app.vue | 2 +- .../components/cells/runner_summary_cell.vue | 2 +- .../runner/components/runner_list.vue | 2 +- .../components/search_tokens/tag_token.vue | 1 - .../components/date/sidebar_date_widget.vue | 2 +- .../components/deployment/deployment_info.vue | 2 +- .../components/mr_widget_header.vue | 2 +- .../components/mr_widget_pipeline.vue | 2 +- .../vue_shared/components/commit.vue | 2 +- .../date_time_picker/date_time_picker.vue | 2 +- .../tokens/author_token.vue | 1 - .../filtered_search_bar/tokens/base_token.vue | 27 +++-- .../tokens/label_token.vue | 1 - .../components/registry/metadata_item.vue | 2 +- .../sidebar/collapsed_grouped_date_picker.vue | 101 ----------------- .../tooltip_on_truncate.stories.js | 88 +++++++++++++++ .../tooltip_on_truncate.vue | 0 .../admin/plan_limits_controller.rb | 1 + ...endency_proxy_for_containers_controller.rb | 2 +- .../projects/pipelines_controller.rb | 17 +++ .../cycle_analytics/project_stage.rb | 6 + app/models/ci/pipeline.rb | 2 +- app/models/commit_status.rb | 3 - app/models/environment.rb | 1 + app/models/instance_configuration.rb | 1 + .../ci/stuck_builds/drop_pending_service.rb | 11 +- ...ice.rb => find_cached_manifest_service.rb} | 27 +---- .../dependency_proxy/pull_manifest_service.rb | 47 -------- .../loose_foreign_keys/cleaner_service.rb | 8 +- .../_package_registry.html.haml | 3 + app/views/groups/settings/_transfer.html.haml | 2 +- .../_package_registry.html.haml | 4 + .../ci_new_query_for_pending_stuck_jobs.yml | 8 -- .../dependency_proxy_manifest_workhorse.yml | 8 -- ...alancing_for_update_all_mirrors_worker.yml | 2 +- ..._analytics_total_unique_counts_monthly.yml | 49 +++++---- ...46_p_analytics_ci_cd_pipelines_monthly.yml | 26 +++++ ...ics_ci_cd_deployment_frequency_monthly.yml | 26 +++++ ...06_p_analytics_ci_cd_lead_time_monthly.yml | 26 +++++ ...4_analytics_total_unique_counts_weekly.yml | 49 +++++---- ...441_p_analytics_ci_cd_pipelines_weekly.yml | 26 +++++ ...tics_ci_cd_deployment_frequency_weekly.yml | 26 +++++ ...200_p_analytics_ci_cd_lead_time_weekly.yml | 26 +++++ ...1126090001_p_analytics_ci_cd_pipelines.yml | 21 ++++ ...p_analytics_ci_cd_deployment_frequency.yml | 21 ++++ ...1126090003_p_analytics_ci_cd_lead_time.yml | 21 ++++ doc/administration/instance_limits.md | 21 ++-- .../database/loose_foreign_keys.md | 16 +-- doc/topics/autodevops/customize.md | 6 +- lib/api/admin/plan_limits.rb | 1 + lib/api/ci/helpers/runner.rb | 14 ++- lib/api/ci/runner.rb | 4 +- lib/api/entities/plan_limit.rb | 1 + .../ci/templates/Auto-DevOps.gitlab-ci.yml | 4 + .../database/gitlab_loose_foreign_keys.yml | 19 ++-- lib/gitlab/database/loose_foreign_keys.rb | 14 +-- lib/gitlab/tracking.rb | 4 +- lib/gitlab/tracking/destinations/snowplow.rb | 14 ++- .../tracking/destinations/snowplow_micro.rb | 5 + .../known_events/analytics.yml | 12 ++ locale/gitlab.pot | 38 ++----- qa/qa/resource/project.rb | 4 + ...cy_proxy_for_containers_controller_spec.rb | 2 +- .../projects/pipelines_controller_spec.rb | 25 ++++- spec/db/schema_spec.rb | 7 +- spec/factories/plan_limits.rb | 1 + .../pipelines/charts/components/app_spec.js | 22 +++- .../blob_viewers/pdf_viewer_spec.js | 22 ++++ .../admin_runners/admin_runners_app_spec.js | 2 +- .../search_tokens/tag_token_spec.js | 2 +- .../tokens/base_token_spec.js | 22 ++-- .../components/registry/metadata_item_spec.js | 2 +- .../collapsed_grouped_date_picker_spec.js | 103 ------------------ .../components/tooltip_on_truncate_spec.js | 2 +- spec/lib/api/entities/plan_limit_spec.rb | 1 + .../database/loose_foreign_keys_spec.rb | 18 +-- .../tracking/destinations/snowplow_spec.rb | 2 +- spec/lib/gitlab/usage_data_spec.rb | 3 + .../cycle_analytics/project_stage_spec.rb | 25 +++++ spec/models/ci/pipeline_spec.rb | 14 +++ spec/models/commit_status_spec.rb | 26 ----- spec/models/instance_configuration_spec.rb | 6 +- spec/requests/api/admin/plan_limits_spec.rb | 7 +- .../api/ci/runner/jobs_artifacts_spec.rb | 12 +- spec/requests/rack_attack_global_spec.rb | 2 +- .../stuck_builds/drop_pending_service_spec.rb | 46 ++------ ...b => find_cached_manifest_service_spec.rb} | 40 +------ .../pull_manifest_service_spec.rb | 77 ------------- .../batch_cleaner_service_spec.rb | 4 +- .../cleaner_service_spec.rb | 4 +- .../unique_visits_shared_examples.rb | 16 ++- .../_package_registry.html.haml_spec.rb | 3 + .../loose_foreign_keys/cleanup_worker_spec.rb | 6 +- 105 files changed, 783 insertions(+), 702 deletions(-) create mode 100644 app/assets/javascripts/repository/components/blob_viewers/pdf_viewer.vue delete mode 100644 app/assets/javascripts/vue_shared/components/sidebar/collapsed_grouped_date_picker.vue create mode 100644 app/assets/javascripts/vue_shared/components/tooltip_on_truncate/tooltip_on_truncate.stories.js rename app/assets/javascripts/vue_shared/components/{ => tooltip_on_truncate}/tooltip_on_truncate.vue (100%) rename app/services/dependency_proxy/{find_or_create_manifest_service.rb => find_cached_manifest_service.rb} (58%) delete mode 100644 app/services/dependency_proxy/pull_manifest_service.rb delete mode 100644 config/feature_flags/development/ci_new_query_for_pending_stuck_jobs.yml delete mode 100644 config/feature_flags/development/dependency_proxy_manifest_workhorse.yml create mode 100644 config/metrics/counts_28d/20211126084446_p_analytics_ci_cd_pipelines_monthly.yml create mode 100644 config/metrics/counts_28d/20211126090835_p_analytics_ci_cd_deployment_frequency_monthly.yml create mode 100644 config/metrics/counts_28d/20211126091206_p_analytics_ci_cd_lead_time_monthly.yml create mode 100644 config/metrics/counts_7d/20211126084441_p_analytics_ci_cd_pipelines_weekly.yml create mode 100644 config/metrics/counts_7d/20211126090829_p_analytics_ci_cd_deployment_frequency_weekly.yml create mode 100644 config/metrics/counts_7d/20211126091200_p_analytics_ci_cd_lead_time_weekly.yml create mode 100644 config/metrics/counts_all/20211126090001_p_analytics_ci_cd_pipelines.yml create mode 100644 config/metrics/counts_all/20211126090002_p_analytics_ci_cd_deployment_frequency.yml create mode 100644 config/metrics/counts_all/20211126090003_p_analytics_ci_cd_lead_time.yml create mode 100644 spec/frontend/repository/components/blob_viewers/pdf_viewer_spec.js delete mode 100644 spec/frontend/vue_shared/components/sidebar/collapsed_grouped_date_picker_spec.js rename spec/services/dependency_proxy/{find_or_create_manifest_service_spec.rb => find_cached_manifest_service_spec.rb} (74%) delete mode 100644 spec/services/dependency_proxy/pull_manifest_service_spec.rb diff --git a/app/assets/javascripts/boards/components/board_card_inner.vue b/app/assets/javascripts/boards/components/board_card_inner.vue index b6ccc6a00fe..ea80496c3f5 100644 --- a/app/assets/javascripts/boards/components/board_card_inner.vue +++ b/app/assets/javascripts/boards/components/board_card_inner.vue @@ -13,7 +13,7 @@ import boardCardInner from 'ee_else_ce/boards/mixins/board_card_inner'; import { isScopedLabel } from '~/lib/utils/common_utils'; import { updateHistory } from '~/lib/utils/url_utility'; import { sprintf, __, n__ } from '~/locale'; -import TooltipOnTruncate from '~/vue_shared/components/tooltip_on_truncate.vue'; +import TooltipOnTruncate from '~/vue_shared/components/tooltip_on_truncate/tooltip_on_truncate.vue'; import UserAvatarLink from '../../vue_shared/components/user_avatar/user_avatar_link.vue'; import { ListType } from '../constants'; import eventHub from '../eventhub'; diff --git a/app/assets/javascripts/ci_settings_pipeline_triggers/components/triggers_list.vue b/app/assets/javascripts/ci_settings_pipeline_triggers/components/triggers_list.vue index 77ec1f1af47..4ab9b36058d 100644 --- a/app/assets/javascripts/ci_settings_pipeline_triggers/components/triggers_list.vue +++ b/app/assets/javascripts/ci_settings_pipeline_triggers/components/triggers_list.vue @@ -3,7 +3,7 @@ import { GlTable, GlButton, GlBadge, GlTooltipDirective } from '@gitlab/ui'; import { s__ } from '~/locale'; import ClipboardButton from '~/vue_shared/components/clipboard_button.vue'; import TimeAgoTooltip from '~/vue_shared/components/time_ago_tooltip.vue'; -import TooltipOnTruncate from '~/vue_shared/components/tooltip_on_truncate.vue'; +import TooltipOnTruncate from '~/vue_shared/components/tooltip_on_truncate/tooltip_on_truncate.vue'; import UserAvatarLink from '~/vue_shared/components/user_avatar/user_avatar_link.vue'; export default { diff --git a/app/assets/javascripts/environments/components/environment_item.vue b/app/assets/javascripts/environments/components/environment_item.vue index db01d455b2b..be9bfb50de5 100644 --- a/app/assets/javascripts/environments/components/environment_item.vue +++ b/app/assets/javascripts/environments/components/environment_item.vue @@ -5,7 +5,7 @@ import { convertObjectPropsToCamelCase } from '~/lib/utils/common_utils'; import { __, s__, sprintf } from '~/locale'; import CiIcon from '~/vue_shared/components/ci_icon.vue'; import CommitComponent from '~/vue_shared/components/commit.vue'; -import TooltipOnTruncate from '~/vue_shared/components/tooltip_on_truncate.vue'; +import TooltipOnTruncate from '~/vue_shared/components/tooltip_on_truncate/tooltip_on_truncate.vue'; import UserAvatarLink from '~/vue_shared/components/user_avatar/user_avatar_link.vue'; import timeagoMixin from '~/vue_shared/mixins/timeago'; import eventHub from '../event_hub'; diff --git a/app/assets/javascripts/error_tracking/components/error_details.vue b/app/assets/javascripts/error_tracking/components/error_details.vue index 4adbf5362b7..e00fec6fddf 100644 --- a/app/assets/javascripts/error_tracking/components/error_details.vue +++ b/app/assets/javascripts/error_tracking/components/error_details.vue @@ -17,7 +17,7 @@ import createFlash from '~/flash'; import { __, sprintf, n__ } from '~/locale'; import Tracking from '~/tracking'; import TimeAgoTooltip from '~/vue_shared/components/time_ago_tooltip.vue'; -import TooltipOnTruncate from '~/vue_shared/components/tooltip_on_truncate.vue'; +import TooltipOnTruncate from '~/vue_shared/components/tooltip_on_truncate/tooltip_on_truncate.vue'; import TrackEventDirective from '~/vue_shared/directives/track_event'; import query from '../queries/details.query.graphql'; import { diff --git a/app/assets/javascripts/issues_list/components/issues_list_app.vue b/app/assets/javascripts/issues_list/components/issues_list_app.vue index 62b672d3e7d..ad810115ef0 100644 --- a/app/assets/javascripts/issues_list/components/issues_list_app.vue +++ b/app/assets/javascripts/issues_list/components/issues_list_app.vue @@ -302,6 +302,7 @@ export default { unique: true, defaultAuthors: [], fetchAuthors: this.fetchUsers, + recentSuggestionsStorageKey: `${this.fullPath}-issues-recent-tokens-author`, preloadedAuthors, }, { @@ -313,6 +314,7 @@ export default { unique: !this.hasMultipleIssueAssigneesFeature, defaultAuthors: DEFAULT_NONE_ANY, fetchAuthors: this.fetchUsers, + recentSuggestionsStorageKey: `${this.fullPath}-issues-recent-tokens-assignee`, preloadedAuthors, }, { @@ -321,6 +323,7 @@ export default { icon: 'clock', token: MilestoneToken, fetchMilestones: this.fetchMilestones, + recentSuggestionsStorageKey: `${this.fullPath}-issues-recent-tokens-milestone`, }, { type: TOKEN_TYPE_LABEL, @@ -329,6 +332,7 @@ export default { token: LabelToken, defaultLabels: DEFAULT_NONE_ANY, fetchLabels: this.fetchLabels, + recentSuggestionsStorageKey: `${this.fullPath}-issues-recent-tokens-label`, }, { type: TOKEN_TYPE_TYPE, @@ -350,6 +354,7 @@ export default { icon: 'rocket', token: ReleaseToken, fetchReleases: this.fetchReleases, + recentSuggestionsStorageKey: `${this.fullPath}-issues-recent-tokens-release`, }); } @@ -361,6 +366,7 @@ export default { token: EmojiToken, unique: true, fetchEmojis: this.fetchEmojis, + recentSuggestionsStorageKey: `${this.fullPath}-issues-recent-tokens-my_reaction`, }); tokens.push({ @@ -446,7 +452,12 @@ export default { query: searchLabelsQuery, variables: { fullPath: this.fullPath, search, isProject: this.isProject }, }) - .then(({ data }) => data[this.namespace]?.labels.nodes); + .then(({ data }) => data[this.namespace]?.labels.nodes) + .then((labels) => + // TODO remove once we can search by title-only on the backend + // https://gitlab.com/gitlab-org/gitlab/-/issues/346353 + labels.filter((label) => label.title.toLowerCase().includes(search.toLowerCase())), + ); }, fetchMilestones(search) { return this.$apollo diff --git a/app/assets/javascripts/jobs/components/sidebar.vue b/app/assets/javascripts/jobs/components/sidebar.vue index 1b50006239c..9aa1503c7c3 100644 --- a/app/assets/javascripts/jobs/components/sidebar.vue +++ b/app/assets/javascripts/jobs/components/sidebar.vue @@ -2,7 +2,7 @@ import { GlButton, GlIcon } from '@gitlab/ui'; import { isEmpty } from 'lodash'; import { mapActions, mapGetters, mapState } from 'vuex'; -import TooltipOnTruncate from '~/vue_shared/components/tooltip_on_truncate.vue'; +import TooltipOnTruncate from '~/vue_shared/components/tooltip_on_truncate/tooltip_on_truncate.vue'; import { JOB_SIDEBAR } from '../constants'; import ArtifactsBlock from './artifacts_block.vue'; import CommitBlock from './commit_block.vue'; diff --git a/app/assets/javascripts/pipeline_editor/components/header/validation_segment.vue b/app/assets/javascripts/pipeline_editor/components/header/validation_segment.vue index 611b78b3c5e..63bffe702ad 100644 --- a/app/assets/javascripts/pipeline_editor/components/header/validation_segment.vue +++ b/app/assets/javascripts/pipeline_editor/components/header/validation_segment.vue @@ -2,7 +2,7 @@ import { GlIcon, GlLink, GlLoadingIcon } from '@gitlab/ui'; import { __, s__, sprintf } from '~/locale'; import getAppStatus from '~/pipeline_editor/graphql/queries/client/app_status.graphql'; -import TooltipOnTruncate from '~/vue_shared/components/tooltip_on_truncate.vue'; +import TooltipOnTruncate from '~/vue_shared/components/tooltip_on_truncate/tooltip_on_truncate.vue'; import { EDITOR_APP_STATUS_EMPTY, EDITOR_APP_STATUS_LOADING, diff --git a/app/assets/javascripts/pipelines/components/pipeline_graph/job_pill.vue b/app/assets/javascripts/pipelines/components/pipeline_graph/job_pill.vue index 836333c8bde..793e343a02a 100644 --- a/app/assets/javascripts/pipelines/components/pipeline_graph/job_pill.vue +++ b/app/assets/javascripts/pipelines/components/pipeline_graph/job_pill.vue @@ -1,5 +1,5 @@