Change always passing visible true tests to false.
This commit is contained in:
parent
ac1584249c
commit
67b06e7a9b
4 changed files with 3 additions and 14 deletions
|
@ -13,11 +13,6 @@ Feature: Project Commits Comments
|
||||||
Scenario: I can't cancel the main form
|
Scenario: I can't cancel the main form
|
||||||
Then I should not see the cancel comment button
|
Then I should not see the cancel comment button
|
||||||
|
|
||||||
@javascript
|
|
||||||
Scenario: I can't preview without text
|
|
||||||
Given I haven't written any comment text
|
|
||||||
Then The comment preview tab should say there is nothing to do
|
|
||||||
|
|
||||||
@javascript
|
@javascript
|
||||||
Scenario: I can preview with text
|
Scenario: I can preview with text
|
||||||
Given I write a comment like ":+1: Nice"
|
Given I write a comment like ":+1: Nice"
|
||||||
|
|
|
@ -54,12 +54,6 @@ Feature: Project Commits Diff Comments
|
||||||
Given I leave a diff comment like "Typo, please fix"
|
Given I leave a diff comment like "Typo, please fix"
|
||||||
Then I should see a discussion reply button
|
Then I should see a discussion reply button
|
||||||
|
|
||||||
@javascript
|
|
||||||
Scenario: I can't preview without text
|
|
||||||
Given I open a diff comment form
|
|
||||||
And I haven't written any diff comment text
|
|
||||||
Then The diff comment preview tab should say there is nothing to do
|
|
||||||
|
|
||||||
@javascript
|
@javascript
|
||||||
Scenario: I can preview with text
|
Scenario: I can preview with text
|
||||||
Given I open a diff comment form
|
Given I open a diff comment form
|
||||||
|
|
|
@ -80,7 +80,7 @@ module SharedDiffNote
|
||||||
|
|
||||||
step 'I should not see the diff comment text field' do
|
step 'I should not see the diff comment text field' do
|
||||||
within(diff_file_selector) do
|
within(diff_file_selector) do
|
||||||
page.should have_css(".js-note-text", visible: false)
|
expect(find('.js-note-text')).not_to be_visible
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
@ -115,7 +115,7 @@ module SharedDiffNote
|
||||||
end
|
end
|
||||||
|
|
||||||
step 'I should see add a diff comment button' do
|
step 'I should see add a diff comment button' do
|
||||||
page.should have_css(".js-add-diff-note-button", visible: false)
|
page.should have_css('.js-add-diff-note-button', visible: true)
|
||||||
end
|
end
|
||||||
|
|
||||||
step 'I should see an empty diff comment form' do
|
step 'I should see an empty diff comment form' do
|
||||||
|
|
|
@ -64,7 +64,7 @@ module SharedNote
|
||||||
|
|
||||||
step 'I should not see the comment text field' do
|
step 'I should not see the comment text field' do
|
||||||
within(".js-main-target-form") do
|
within(".js-main-target-form") do
|
||||||
page.should have_css(".js-note-text", visible: false)
|
expect(find('.js-note-text')).not_to be_visible
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue