Minor refactor based on review feedback

This commit is contained in:
kushalpandya 2017-06-02 18:05:47 +05:30
parent b487a32cc0
commit 6838c16c49
2 changed files with 3 additions and 2 deletions

View File

@ -23,6 +23,6 @@
- elsif type == 'select'
= form.select name, options_for_select(choices, value ? value : default_choice), {}, { class: "form-control" }
- elsif type == 'password'
= form.password_field name, autocomplete: "new-password", class: "form-control", required: value.present? ? nil : :required
= form.password_field name, autocomplete: "new-password", class: "form-control", required: value.blank? && :required
- if help
%span.help-block= help

View File

@ -65,7 +65,8 @@ feature 'Setup Jira service', :feature, :js do
click_button('Test settings and save changes')
wait_for_requests
expect(page).to have_content('Test failed.Save anyway')
expect(find('.flash-container-page')).to have_content 'Test failed.'
expect(find('.flash-container-page')).to have_content 'Save anyway'
find('.flash-alert .flash-action').trigger('click')
wait_for_requests