From 68b5ded0565f3899753173cd294f77607c462dcf Mon Sep 17 00:00:00 2001 From: Lin Jen-Shin Date: Thu, 31 Mar 2016 22:30:36 +0800 Subject: [PATCH] No need to check project because: sent_notification.project would never be nil, and we also have already checked message_project before entering process_create_issue. --- lib/gitlab/email/receiver.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/gitlab/email/receiver.rb b/lib/gitlab/email/receiver.rb index 5b55a045cbe..0792116ed2d 100644 --- a/lib/gitlab/email/receiver.rb +++ b/lib/gitlab/email/receiver.rb @@ -79,8 +79,7 @@ module Gitlab raise UserNotFoundError unless author raise UserBlockedError if author.blocked? # TODO: Give project not found error if author cannot read project - raise UserNotAuthorizedError if project.nil? || - !author.can?(permission, project) + raise UserNotAuthorizedError unless author.can?(permission, project) end # Find the first matched user in database from email From: section