Add a scope for visible services, code styling changes for easier readability.

This commit is contained in:
Marin Jankovski 2015-01-28 14:25:55 -08:00
parent c6c7552e41
commit 68f7302474
4 changed files with 5 additions and 7 deletions

View File

@ -9,7 +9,7 @@ class Projects::ServicesController < Projects::ApplicationController
def index
@project.build_missing_services
@services = @project.services.where.not(type: 'GitlabIssueTrackerService').reload
@services = @project.services.visible.reload
end
def edit

View File

@ -317,11 +317,7 @@ class Project < ActiveRecord::Base
end
def default_issue_tracker
unless gitlab_issue_tracker_service
create_gitlab_issue_tracker_service
end
gitlab_issue_tracker_service
gitlab_issue_tracker_service ||= create_gitlab_issue_tracker_service
end
def issues_tracker

View File

@ -20,6 +20,6 @@ class GitlabIssueTrackerService < IssueTrackerService
end
def issue_url(iid)
"#{Gitlab.config.gitlab.url}#{project_issue_path project_id: project, id: iid}"
"#{Gitlab.config.gitlab.url}#{project_issue_path(project_id: project, id: iid)}"
end
end

View File

@ -26,6 +26,8 @@ class Service < ActiveRecord::Base
validates :project_id, presence: true
scope :visible, -> { where.not(type: 'GitlabIssueTrackerService') }
def activated?
active
end