From 6c8919627824648a8a4275832c67dedff5bd3e3f Mon Sep 17 00:00:00 2001
From: Phil Hughes <me@iamphill.com>
Date: Tue, 8 Mar 2016 16:53:31 +0000
Subject: [PATCH] Enter button trigger first row click when searching

---
 app/assets/javascripts/gl_dropdown.js.coffee  | 39 ++++++++++++++-----
 .../stylesheets/framework/dropdowns.scss      |  2 +-
 2 files changed, 30 insertions(+), 11 deletions(-)

diff --git a/app/assets/javascripts/gl_dropdown.js.coffee b/app/assets/javascripts/gl_dropdown.js.coffee
index a162955d39a..420f67ef19e 100644
--- a/app/assets/javascripts/gl_dropdown.js.coffee
+++ b/app/assets/javascripts/gl_dropdown.js.coffee
@@ -1,12 +1,17 @@
 class GitLabDropdownFilter
   BLUR_KEYCODES = [27, 40]
 
-  constructor: (@dropdown, @remote, @query, @keys, @data, @callback) ->
+  constructor: (@dropdown, @options) ->
     @input = @dropdown.find(".dropdown-input .dropdown-input-field")
 
     # Key events
     timeout = ""
     @input.on "keyup", (e) =>
+      if e.keyCode is 13 && @input.val() isnt ""
+        if @options.enterCallback
+          @options.enterCallback()
+        return
+
       clearTimeout timeout
       timeout = setTimeout =>
         blur_field = @shouldBlur e.keyCode
@@ -15,9 +20,9 @@ class GitLabDropdownFilter
         if blur_field
           @input.blur()
 
-        if @remote
-          @query search_text, (data) =>
-            @callback(data)
+        if @options.remote
+          @options.query search_text, (data) =>
+            @options.callback(data)
         else
           @filter search_text
       , 250
@@ -26,12 +31,12 @@ class GitLabDropdownFilter
     return BLUR_KEYCODES.indexOf(keyCode) >= 0
 
   filter: (search_text) ->
-    data = @data()
+    data = @options.data()
     results = data
 
     if search_text isnt ""
       results = fuzzaldrinPlus.filter(data, search_text,
-        key: @keys
+        key: @options.keys
       )
 
     @callback results
@@ -89,10 +94,16 @@ class GitLabDropdown
 
     # Init filiterable
     if @options.filterable
-      @filter = new GitLabDropdownFilter @dropdown, @options.filterRemote, @options.data, @options.search.fields, =>
-        return @fullData
-      , (data) =>
-        @parseData data
+      @filter = new GitLabDropdownFilter @dropdown,
+        remote: @options.filterRemote
+        query: @options.data
+        keys: @options.search.fields
+        data: =>
+          return @fullData
+        callback: (data) =>
+          @parseData data
+        enterCallback: =>
+          @selectFirstRow()
 
     # Event listeners
     @dropdown.on "shown.bs.dropdown", @opened
@@ -234,6 +245,14 @@ class GitLabDropdown
       input = "<input type='hidden' name='#{fieldName}' value='#{value}' />"
       @dropdown.before input
 
+  selectFirstRow: ->
+    selector = '.dropdown-content li:first-child a'
+    if @dropdown.find(".dropdown-toggle-page").length
+      selector = ".dropdown-page-one .dropdown-content li:first-child a"
+
+    # similute a click on the first link
+    $(selector).trigger "click"
+
 $.fn.glDropdown = (opts) ->
   return @.each ->
     new GitLabDropdown @, opts
diff --git a/app/assets/stylesheets/framework/dropdowns.scss b/app/assets/stylesheets/framework/dropdowns.scss
index 6d3e48437b7..009d621fc74 100644
--- a/app/assets/stylesheets/framework/dropdowns.scss
+++ b/app/assets/stylesheets/framework/dropdowns.scss
@@ -65,7 +65,7 @@
   position: absolute;
   top: 100%;
   left: 0;
-  z-index: 9999;
+  z-index: 9;
   width: 240px;
   margin-top: 2px;
   margin-bottom: 0;