Merge branch '46740-projectmilestones-setting-start_date-via-the-api-requires-a-second-parameter' into 'master'

Resolve "ProjectMilestones: Setting start_date via the API requires a second parameter"

Closes #46740

See merge request gitlab-org/gitlab-ce!19133
This commit is contained in:
Rémy Coutable 2018-05-25 17:27:31 +00:00
commit 6f4935bcee
2 changed files with 7 additions and 1 deletions

View File

@ -24,7 +24,7 @@ module API
optional :state_event, type: String, values: %w[close activate],
desc: 'The state event of the milestone '
use :optional_params
at_least_one_of :title, :description, :due_date, :state_event
at_least_one_of :title, :description, :start_date, :due_date, :state_event
end
def list_milestones_for(parent)

View File

@ -196,6 +196,12 @@ shared_examples_for 'group and project milestones' do |route_definition|
expect(json_response['state']).to eq('closed')
end
it 'updates milestone with only start date' do
put api(resource_route, user), start_date: Date.tomorrow
expect(response).to have_gitlab_http_status(200)
end
end
describe "GET #{route_definition}/:milestone_id/issues" do