Fix a logic error in ProjectTeam#fetch_invited_members
We were calling `.where` and `.send` on the relation, but never doing anything with the return value, resulting in proper access-level filtering never being of any consequence.
This commit is contained in:
parent
b7b41d1f68
commit
6f558121b4
2 changed files with 3 additions and 2 deletions
|
@ -248,9 +248,9 @@ class ProjectTeam
|
|||
# group access is developers we need to provide
|
||||
# both group master, developers as devs
|
||||
if int_level == group_link.group_access
|
||||
im.where("access_level >= ?)", group_link.group_access)
|
||||
im = im.where("access_level >= ?", group_link.group_access)
|
||||
else
|
||||
im.send(level)
|
||||
im = im.send(level)
|
||||
end
|
||||
end
|
||||
|
||||
|
|
|
@ -111,6 +111,7 @@ describe ProjectTeam, models: true do
|
|||
group_access: Gitlab::Access::REPORTER
|
||||
)
|
||||
|
||||
expect(project.team.guests).to be_empty
|
||||
expect(project.team.reporters).to contain_exactly(group_member.user)
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Reference in a new issue