From 70156f3b8e277ffeba2a6c37d15ec2669fb432d7 Mon Sep 17 00:00:00 2001 From: Oswaldo Ferreira Date: Tue, 20 Feb 2018 19:04:10 -0300 Subject: [PATCH] Memoize method which is called multiple times on presenter --- app/presenters/project_presenter.rb | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/app/presenters/project_presenter.rb b/app/presenters/project_presenter.rb index 8dca777212e..843651682eb 100644 --- a/app/presenters/project_presenter.rb +++ b/app/presenters/project_presenter.rb @@ -4,6 +4,7 @@ class ProjectPresenter < Gitlab::View::Presenter::Delegated include GitlabRoutingHelper include StorageHelper include TreeHelper + include Gitlab::Utils::StrongMemoize presents :project @@ -159,10 +160,12 @@ class ProjectPresenter < Gitlab::View::Presenter::Delegated end def can_current_user_push_code? - if empty_repo? - can?(current_user, :push_code, project) - else - user_can_push_to_branch?(current_user, default_branch) + strong_memoize(:can_current_user_push_code) do + if empty_repo? + can?(current_user, :push_code, project) + else + user_can_push_to_branch?(current_user, default_branch) + end end end