kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Remove vue from main.bundle.js file being loaded through `app/assets/javascripts/merge_request_tabs.js`

This commit is contained in:
Filipa Lacerda 2017-06-21 04:42:15 +01:00
parent b2e1d32e7a
commit 701c1e1ece
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/assets/javascripts/commit/pipelines/pipelines_bundle.js
View File

@ -10,6 +10,11 @@ import commitPipelinesTable from './pipelines_table.vue';
const CommitPipelinesTable = Vue.extend(commitPipelinesTable);
// export for use in merge_request_tabs.js (TODO: remove this hack when we understand how to load
// vue.js in merge_request_tabs.js)
window.gl = window.gl || {};
window.gl.CommitPipelinesTable = CommitPipelinesTable;
document.addEventListener('DOMContentLoaded', () => {
const pipelineTableViewEl = document.querySelector('#commit-pipeline-table-view');

4
app/assets/javascripts/merge_request_tabs.js
View File

@ -3,12 +3,10 @@
/* global Flash */
/* global notes */
import Vue from 'vue';
import Cookies from 'js-cookie';
import './breakpoints';
import './flash';
import BlobForkSuggestion from './blob/blob_fork_suggestion';
import commitPipelinesTable from './commit/pipelines/pipelines_table.vue';
/* eslint-disable max-len */
// MergeRequestTabs
@ -236,7 +234,7 @@ import commitPipelinesTable from './commit/pipelines/pipelines_table.vue';
mountPipelinesView() {
const pipelineTableViewEl = document.querySelector('#commit-pipeline-table-view');
const CommitPipelinesTable = Vue.extend(commitPipelinesTable);
const CommitPipelinesTable = gl.CommitPipelinesTable;
this.commitPipelinesTable = new CommitPipelinesTable({
propsData: {
endpoint: pipelineTableViewEl.dataset.endpoint,