Remove gitlab-ui's tooltip from global

This commit is contained in:
Clement Ho 2018-11-05 16:48:55 +00:00 committed by Filipa Lacerda
parent 3429d35763
commit 701f0f5e55
5 changed files with 18 additions and 4 deletions

View File

@ -1,6 +1,4 @@
import Vue from 'vue'; import Vue from 'vue';
import { GlLoadingIcon, GlTooltipDirective } from '@gitlab-org/gitlab-ui'; import { GlLoadingIcon } from '@gitlab-org/gitlab-ui';
Vue.component('gl-loading-icon', GlLoadingIcon); Vue.component('gl-loading-icon', GlLoadingIcon);
Vue.directive('gl-tooltip', GlTooltipDirective);

View File

@ -3,6 +3,7 @@ import { mapActions } from 'vuex';
import Icon from '~/vue_shared/components/icon.vue'; import Icon from '~/vue_shared/components/icon.vue';
import { pluralize, truncate } from '~/lib/utils/text_utility'; import { pluralize, truncate } from '~/lib/utils/text_utility';
import UserAvatarImage from '~/vue_shared/components/user_avatar/user_avatar_image.vue'; import UserAvatarImage from '~/vue_shared/components/user_avatar/user_avatar_image.vue';
import { GlTooltipDirective } from '@gitlab-org/gitlab-ui';
import { COUNT_OF_AVATARS_IN_GUTTER, LENGTH_OF_AVATAR_TOOLTIP } from '../constants'; import { COUNT_OF_AVATARS_IN_GUTTER, LENGTH_OF_AVATAR_TOOLTIP } from '../constants';
export default { export default {
@ -10,6 +11,9 @@ export default {
Icon, Icon,
UserAvatarImage, UserAvatarImage,
}, },
directives: {
GlTooltip: GlTooltipDirective,
},
props: { props: {
discussions: { discussions: {
type: Array, type: Array,

View File

@ -5,7 +5,7 @@ import Icon from '~/vue_shared/components/icon.vue';
import GfmAutoComplete from '~/gfm_auto_complete'; import GfmAutoComplete from '~/gfm_auto_complete';
import { __, s__ } from '~/locale'; import { __, s__ } from '~/locale';
import Api from '~/api'; import Api from '~/api';
import { GlModal } from '@gitlab-org/gitlab-ui'; import { GlModal, GlTooltipDirective } from '@gitlab-org/gitlab-ui';
import eventHub from './event_hub'; import eventHub from './event_hub';
import EmojiMenuInModal from './emoji_menu_in_modal'; import EmojiMenuInModal from './emoji_menu_in_modal';
@ -16,6 +16,9 @@ export default {
Icon, Icon,
GlModal, GlModal,
}, },
directives: {
GlTooltip: GlTooltipDirective,
},
props: { props: {
currentEmoji: { currentEmoji: {
type: String, type: String,

View File

@ -1,10 +1,14 @@
<script> <script>
import { calculateRemainingMilliseconds, formatTime } from '~/lib/utils/datetime_utility'; import { calculateRemainingMilliseconds, formatTime } from '~/lib/utils/datetime_utility';
import { GlTooltipDirective } from '@gitlab-org/gitlab-ui';
/** /**
* Counts down to a given end date. * Counts down to a given end date.
*/ */
export default { export default {
directives: {
GlTooltip: GlTooltipDirective,
},
props: { props: {
endDateString: { endDateString: {
type: String, type: String,

View File

@ -0,0 +1,5 @@
---
title: Remove gitlab-ui's tooltip from global
merge_request:
author:
type: performance