From a4f9ef7d79f0a9e61e6c3aaf1c4a5670324d837d Mon Sep 17 00:00:00 2001 From: blackst0ne Date: Sat, 16 Jun 2018 13:16:48 +1100 Subject: [PATCH] [Rails5] Fix "'-1' is not a valid data_store" Part of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19882 --- .../unreleased/blackst0ne-rails5-fix-data-store-spec.yml | 5 +++++ spec/models/ci/build_trace_chunk_spec.rb | 8 -------- 2 files changed, 5 insertions(+), 8 deletions(-) create mode 100644 changelogs/unreleased/blackst0ne-rails5-fix-data-store-spec.yml diff --git a/changelogs/unreleased/blackst0ne-rails5-fix-data-store-spec.yml b/changelogs/unreleased/blackst0ne-rails5-fix-data-store-spec.yml new file mode 100644 index 00000000000..403c3764321 --- /dev/null +++ b/changelogs/unreleased/blackst0ne-rails5-fix-data-store-spec.yml @@ -0,0 +1,5 @@ +--- +title: '[Rails5] Fix "-1 is not a valid data_store"' +merge_request: 19917 +author: "@blackst0ne" +type: fixed diff --git a/spec/models/ci/build_trace_chunk_spec.rb b/spec/models/ci/build_trace_chunk_spec.rb index b5a6d959ccb..c5d550cba1b 100644 --- a/spec/models/ci/build_trace_chunk_spec.rb +++ b/spec/models/ci/build_trace_chunk_spec.rb @@ -125,14 +125,6 @@ describe Ci::BuildTraceChunk, :clean_gitlab_redis_shared_state do end end end - - context 'when data_store is others' do - before do - build_trace_chunk.send(:write_attribute, :data_store, -1) - end - - it { expect { subject }.to raise_error('Unsupported data store') } - end end describe '#truncate' do