From 70ce746bd011b101605e6d84f141d1f0c3175831 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 13 Oct 2022 12:10:13 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/caching.gitlab-ci.yml | 12 + .gitlab/ci/review.gitlab-ci.yml | 2 +- .gitlab/ci/rules.gitlab-ci.yml | 23 +- .../components/sticky_header.vue | 1 + app/helpers/projects_helper.rb | 16 + app/models/namespace.rb | 4 + app/models/namespace/package_setting.rb | 6 + app/models/project.rb | 5 + .../ci/parse_dotenv_artifact_service.rb | 2 +- app/services/merge_requests/update_service.rb | 13 +- app/views/shared/projects/_project.html.haml | 2 +- .../cascade_package_forwarding_settings.yml | 8 + ...d_ci_job_variables_raw_with_new_default.rb | 12 + db/schema_migrations/20221011113928 | 1 + doc/api/users.md | 2 +- doc/user/project/deploy_tokens/index.md | 127 ++--- lib/api/concerns/packages/npm_endpoints.rb | 7 +- .../packages/dependency_proxy_helpers.rb | 18 +- lib/api/maven_packages.rb | 8 +- lib/api/pypi_packages.rb | 7 +- locale/gitlab.pot | 18 + scripts/packages/automated_cleanup.rb | 120 +++++ scripts/review_apps/automated_cleanup.rb | 466 +++++++++--------- scripts/utils.sh | 6 +- spec/helpers/projects_helper_spec.rb | 20 + .../packages/dependency_proxy_helpers_spec.rb | 66 ++- ...cading_namespace_setting_attribute_spec.rb | 347 ------------- spec/models/namespace/package_setting_spec.rb | 9 + spec/models/namespace_setting_spec.rb | 4 + spec/models/namespace_spec.rb | 3 + spec/models/project_spec.rb | 3 + spec/requests/api/maven_packages_spec.rb | 4 +- .../merge_requests/update_service_spec.rb | 12 + ...dependency_proxy_helpers_shared_context.rb | 5 + ...ading_namespace_setting_shared_examples.rb | 355 +++++++++++++ .../api/npm_packages_shared_examples.rb | 6 +- .../api/npm_packages_tags_shared_examples.rb | 1 + .../api/pypi_packages_shared_examples.rb | 2 +- 38 files changed, 1055 insertions(+), 668 deletions(-) create mode 100644 config/feature_flags/development/cascade_package_forwarding_settings.yml create mode 100644 db/post_migrate/20221011113928_redo_remove_and_add_ci_job_variables_raw_with_new_default.rb create mode 100644 db/schema_migrations/20221011113928 create mode 100755 scripts/packages/automated_cleanup.rb delete mode 100644 spec/models/concerns/cascading_namespace_setting_attribute_spec.rb create mode 100644 spec/support/shared_examples/models/concerns/cascading_namespace_setting_shared_examples.rb diff --git a/.gitlab/ci/caching.gitlab-ci.yml b/.gitlab/ci/caching.gitlab-ci.yml index 589032e66ea..97d4f2f7264 100644 --- a/.gitlab/ci/caching.gitlab-ci.yml +++ b/.gitlab/ci/caching.gitlab-ci.yml @@ -51,3 +51,15 @@ cache-assets:production: variables: NODE_ENV: "production" RAILS_ENV: "production" + +packages-cleanup: + extends: + - .default-retry + - .caching:rules:packages-cleanup + image: ${GITLAB_DEPENDENCY_PROXY}ruby:${RUBY_VERSION} + stage: prepare + before_script: + - source scripts/utils.sh + - install_gitlab_gem + script: + - scripts/packages/automated_cleanup.rb diff --git a/.gitlab/ci/review.gitlab-ci.yml b/.gitlab/ci/review.gitlab-ci.yml index 5903b0ba7f7..aefa96da159 100644 --- a/.gitlab/ci/review.gitlab-ci.yml +++ b/.gitlab/ci/review.gitlab-ci.yml @@ -17,7 +17,7 @@ review-cleanup: script: - delete_release - delete_namespace - - ruby -rrubygems scripts/review_apps/automated_cleanup.rb + - scripts/review_apps/automated_cleanup.rb - gcp_cleanup start-review-app-pipeline: diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index 35909ca8637..c876dfef27c 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -673,7 +673,9 @@ ################# .caching:rules:cache-workhorse: rules: - - <<: *if-dot-com-ee-schedule + # That would run for any project that has a "maintenance" pipeline schedule + # but in fact, the cache package is only uploaded for gitlab.com/gitlab-org/gitlab and jihulab.com/gitlab-cn/gitlab + - <<: *if-default-branch-schedule-maintenance - <<: *if-dot-com-gitlab-org-default-branch changes: ["workhorse/**/*"] - <<: *if-dot-com-gitlab-org-merge-request @@ -688,7 +690,9 @@ # The new strategy to cache assets as generic packages is experimental and can be disabled by removing the `CACHE_ASSETS_AS_PACKAGE` variable - if: '$CACHE_ASSETS_AS_PACKAGE != "true"' when: never - - <<: *if-dot-com-ee-schedule + # That would run for any project that has a "maintenance" pipeline schedule + # but in fact, the cache package is only uploaded for gitlab.com/gitlab-org/gitlab and jihulab.com/gitlab-cn/gitlab + - <<: *if-default-branch-schedule-maintenance - <<: *if-dot-com-gitlab-org-default-branch changes: *assets-compilation-patterns - <<: *if-dot-com-gitlab-org-merge-request @@ -699,6 +703,21 @@ when: manual allow_failure: true +.caching:rules:packages-cleanup: + rules: + # The new strategy to cache assets as generic packages is experimental and can be disabled by removing the `CACHE_ASSETS_AS_PACKAGE` variable + - if: '$CACHE_ASSETS_AS_PACKAGE != "true"' + when: never + # That would run for any project that has a "maintenance" pipeline schedule + # but in fact, the cache package is only uploaded for gitlab.com/gitlab-org/gitlab and jihulab.com/gitlab-cn/gitlab + - <<: *if-default-branch-schedule-maintenance + - <<: *if-dot-com-gitlab-org-merge-request + changes: + - ".gitlab/ci/caching.gitlab-ci.yml" + - "scripts/packages/automated_cleanup.rb" + when: manual + allow_failure: true + ###################### # CI Templates Rules # ###################### diff --git a/app/assets/javascripts/merge_requests/components/sticky_header.vue b/app/assets/javascripts/merge_requests/components/sticky_header.vue index f067982fce1..b7629ba001f 100644 --- a/app/assets/javascripts/merge_requests/components/sticky_header.vue +++ b/app/assets/javascripts/merge_requests/components/sticky_header.vue @@ -86,6 +86,7 @@ export default {