From 71722304bef22d1b162207e3e25e4109b0d0f8c1 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 1 Feb 2022 21:12:02 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop.yml | 1 + app/assets/images/auth_buttons/auth0_64.png | Bin 1815 -> 2873 bytes app/assets/javascripts/activities.js | 4 +- app/assets/javascripts/awards_handler.js | 8 +- .../behaviors/shortcuts/shortcuts.js | 14 ++-- .../blob/pipeline_tour_success_modal.vue | 6 +- .../javascripts/broadcast_notification.js | 4 +- .../components/ci_variable_modal.vue | 6 +- app/assets/javascripts/contextual_sidebar.js | 7 +- .../cycle_analytics/components/base.vue | 6 +- app/assets/javascripts/deprecated_notes.js | 6 +- .../components/design_sidebar.vue | 8 +- app/assets/javascripts/diffs/index.js | 12 +-- app/assets/javascripts/diffs/store/actions.js | 13 +++- app/assets/javascripts/diffs/store/getters.js | 4 +- .../diffs/store/modules/diff_state.js | 4 +- .../javascripts/emoji/components/utils.js | 8 +- .../javascripts/files_comment_button.js | 4 +- app/assets/javascripts/groups/landing.js | 7 +- .../javascripts/issuable/issuable_context.js | 4 +- .../javascripts/lib/utils/common_utils.js | 5 +- .../merge_conflicts/store/actions.js | 4 +- .../merge_conflicts/store/state.js | 4 +- app/assets/javascripts/merge_request_tabs.js | 17 +++-- .../components/pipeline_schedules_callout.vue | 8 +- .../javascripts/pages/projects/project.js | 8 +- app/assets/javascripts/pages/users/index.js | 4 +- app/assets/javascripts/right_sidebar.js | 4 +- .../javascripts/serverless/survey_banner.vue | 7 +- app/assets/javascripts/user_callout.js | 6 +- app/assets/javascripts/vue_alerts.js | 6 +- .../components/issuable_sidebar_root.vue | 8 +- .../stylesheets/pages/merge_requests.scss | 3 +- app/controllers/graphql_controller.rb | 6 ++ app/finders/users_finder.rb | 6 +- app/helpers/projects_helper.rb | 18 +++-- .../development/jobs_tab_vue.yml | 2 +- ...code_review_user_jetbrains_api_request.yml | 8 ++ .../004_zeitwerk.rb | 1 + config/metrics/aggregates/code_review.yml | 2 + ...644_user_jetbrains_api_request_monthly.yml | 26 +++++++ ...0634_user_jetbrains_api_request_weekly.yml | 26 +++++++ ...212_add_user_details_provisioning_index.rb | 18 +++++ db/schema_migrations/20220201173212 | 1 + db/structure.sql | 4 +- .../packages/container_registry.md | 40 ++++++++++ doc/api/groups.md | 72 ++++++++++++++++++ doc/ci/runners/configure_runners.md | 4 - lib/api/api.rb | 4 + lib/gitlab/gon_helper.rb | 1 + ...etbrains_plugin_activity_unique_counter.rb | 28 +++++++ .../known_events/code_review_events.yml | 5 ++ qa/qa.rb | 3 +- qa/qa/tools/reliable_report.rb | 2 +- qa/spec/tools/reliable_report_spec.rb | 2 +- spec/controllers/graphql_controller_spec.rb | 20 +++++ spec/frontend/broadcast_notification_spec.js | 1 + .../components/step_spec.js | 2 +- .../components/design_sidebar_spec.js | 5 +- spec/frontend/emoji/components/utils_spec.js | 3 + spec/frontend/groups/landing_spec.js | 5 +- .../merge_conflicts/store/actions_spec.js | 5 +- .../pipeline_schedule_callout_spec.js | 1 + .../frontend/serverless/survey_banner_spec.js | 5 +- .../components/issuable_sidebar_root_spec.js | 5 +- spec/lib/gitlab/gon_helper_spec.rb | 32 ++++++++ ...ins_plugin_activity_unique_counter_spec.rb | 63 +++++++++++++++ ...d_project_packages_list_shared_examples.rb | 56 ++++++++------ 68 files changed, 543 insertions(+), 149 deletions(-) create mode 100644 config/feature_flags/development/usage_data_i_code_review_user_jetbrains_api_request.yml create mode 100644 config/metrics/counts_28d/20220121140644_user_jetbrains_api_request_monthly.yml create mode 100644 config/metrics/counts_7d/20220121140634_user_jetbrains_api_request_weekly.yml create mode 100644 db/post_migrate/20220201173212_add_user_details_provisioning_index.rb create mode 100644 db/schema_migrations/20220201173212 create mode 100644 lib/gitlab/usage_data_counters/jetbrains_plugin_activity_unique_counter.rb create mode 100644 spec/lib/gitlab/usage_data_counters/jetbrains_plugin_activity_unique_counter_spec.rb diff --git a/.rubocop.yml b/.rubocop.yml index bea2cf66efd..5757a273926 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -168,6 +168,7 @@ Naming/FileName: - GitLab - JavaScript - VSCode + - JetBrains # default ones: - CLI - DSL diff --git a/app/assets/images/auth_buttons/auth0_64.png b/app/assets/images/auth_buttons/auth0_64.png index 5ad596593801bffdc9f11c70f4021ffb17ac8341..3b2d8562d9dd443cf81e50cd9743413cc0caccdf 100644 GIT binary patch literal 2873 zcmaJ@cUY5G7Y{3n3JwIy5JO~rj0{GAKp2uBD?kw~vk;P(BuEA!Bq0b65TS@wKx8N) zpj1(aj1obXfQ8}!8L~Hs3k-@Pqy2)d_WQ$r_j%s;j_3S-=XcIM_dYk-)BS+l7S$~v z5J=A13F{^9?KZy6VDbMZHDXlUsjzWA?1PL@HkZHxK=vd?2mo=W5y*fSKp;g&v;)>4 zkdzM9+lTFgcS92yG#FvS2F9Z?#b^-7+Lp&85RU+CNC-ft(lOA5+6E|uO2R;YFvBD8 zOb38Mb>g#tgM4>yBL4`{k_5H2fmrjX+sh(H)akVq5^i83`up$s9$2xBB1VGKuF8X23Qkq9)x9P)RA zirukDp=d9xuJ#ya{ z1}qRsWKo%HDuWK$U?hYvqSzRySn6Lf(3oFo>5+fuNt`h_kHCZ@VTg^Gz8K>1|KF5G z`)VD@_5%LV`%U6V?`S3f_W~jrQ7oc(=R)^wxMHFmSO9^|V0kkb;a}3|Nnx-VkrW0K zVvK|tL-g#k7N_*M8Fw~fr?3BR4NJWh{a(o%=hCENJ|SO66aun zvNy*eux1XH_Kubo_6}dLSOzhQ2GH4Gu%v&mj{l0?C=_HNs2qUg$YRhSpQA=o zzo7+Xg0Q!+bll)WeOt?4SkgDNe8$=%5dVsWi^ae<_V$1F`pc5IfHsC-OIJMkTKoWA zT=6V%X}`ff?gN1~-EhX*d-Dc+{Aq5x4}4cIHE)q`r-_xPEO$<-9CQh@+pI_}gh-q^ zzBw73(iF5N=yFsGBOMDBif_k|rc}d^8-Cxab7P6WKG)gl$#QZ^x^NS$dR%8r7(q;Nu&6jX*Ll_Byzh|A4}O6* zmH3!Xi!)HgDQ_>YrwI=SOZ7@kZcHmJ;^#l^+aw-XcQnLgw4a%ra}IJ9l??lMZ

+8vt7!dINY3)sv0#!*OkvPGxi_1FWV4yAw9yog~=~jDBt%qI;`j?KAQk8ZJ zl@WK=gqVW5I*gUJ_RPiZVvj4^wrnX+pD(;n>u~^zG5J*RUeReFGcywtT4Cun|Hr-$ zYN4T_roFwrSM2-&0I2&-)6>sy<#IP*mhHwLEc?~Z#MB}%obt{>+E6J)2ZiEvn$c~! z^8qh9^fiV9KdR)*sYa`T(zid@!u@UZjv*5fo%J*(7s`B6QftkeZ&IMLk6;X=-X76HC8PR>@<6l>J6K+lD~d z+1ci;d>?IX?J?`?;O2)zFHzJJ)PkkVKOy22~M6`EUj*l+M4Ah+%M(} zAH8?iHL(G6Z29d(dPPM=oQv#fS}@2}-(y4No1yCJ^8S-GF(2pEZnZY+q!^(o({iVq zo11lK67v!$eb-zs{^Ywis!1ojqpG=AcuS&9s7kn_;vWz&e7{CQ9i==oI1v`m2Li_v zJYjYrA(M6ZT$G%E4(d;!-Q@^XFPhnjPa%WV{A6uy?eOixwQV&L!3w_uIle3kd#`*0 zPjufFjpqA2*6JP@$iCjA4;o?#?bS^A!#nj23|0^8gJjM3vYPRk13OD?Gk)JbC~b~w zCv`)rjsawH^$Rw-*5#`7P~$n|dDLe5PwsfUj7wcbcVFLiq50-*H@Io}sV@V@=ei2b zLL~Zb`I@Y(eR>D-(^ODUC{t2YjQ#lxd63@-%Jhlr)S3;(?%lBip$!fmtB(!p{z(|O zzLJ@ckT7;RN_2)>xpYE1QLWN0{g>vheFx4ay_8v6TKcrVg@(#qSr$$8hE)yDhE}vD zj(Iw^$qQPT@k(9A%|hXBMMYed)~=6>9$uqUc@yia9~GSR^m(I6#(J;Xl?2C~o8?pk z;H2alO_pd9cQX^Fr?>olFqiXlmVfZskvU9WxMcbRCDXPVZO(Y(i6^J*9$&Ft$b4Nv zesWS@U%&ob4ZRQ+F07DqySg$CTg_3oF3!lv@YkTnX6?0&Q*XNcY-HrJ%i4UVScI?$Y&ZYvmFti3pDNw zphhJx-si`}JWJ=TG~|shEZCYD8y9fZZ@$)&|2@fTGElvAXRw4q|M+;hxux{k5YuE1 zu3edz+A?cv^<+50$?MRerR=Bo@2X@qaz+7=E>of80De{1q%>Jrcw*CbjkPo^*_D)< z+7S8tvDHmQCn}XXQq+-~R9tKm^CA2Yg)(<*d5@&Z31=GZO-y}#eZ}Y>E04E@GtU*; zbJ&hL>JEJV3Z9X&Nk=fVNZwW8cl+=d@wc z4_0$wd9P_bqgR)Ng@xJds0b)9e3@VRbnPA|Z%ll!Ya*r|{HQ6?i!UFYoauFy6JJ__ z^78Ub59>Gw6$Z=i{1GFqtbrN6rmp#D+{oU*oMAG=c__Qru4| Sy6xI{%sS)Tv8DTiPyQF}Gv!qP delta 1801 zcmV+k2ln{67MBi?BYy_oNkl4?{w>u2u!!EQx(T#b3#P5v&y*QI`iIytBLLifJ7{l%YJl}K13=0MS1nW#uE3w|%V5^b3~0qHV(^F7 z{PcxBWq$(T*VQmt&ERqI@SZjN!=fU_iigXoJC7vQBI+nC^o2f&_00)@uu2o)mi7R% zJpzpR)e;!LhzP~%$qN8~Bh*n)=mXhDpQ=9Aa{^E`I8#=Ih>y3$z~^TpStNib25-`* z*x>A@00=OK9rU6^^{cBx0vz+rJQ#PRIsX2f7=K3$j+DUq5Z155m&k~801T#Y3`LV4 z5{QR7Jj_2*obRq+K9=xld!sLmFaBaEo(4cyE0!07?vy0vdv~>U_=O1-i>w1(qx7w- zf))A$;LiRU*>EZIgi+0L20CJJQL^f(@d$lvwgq-?7J$fqYx<_<)I=x=xCcG zAb+Ee%@}Z=M44mzb{;Z3Y=+D6H|NLL;^S~D?Gk3r3(idkfYDc)g7htMzqDZ9A*XyR z=Hc84<@59-e@X>_H8cqaRpt4%vCvtzu-GX9zL989&C{z>0jO25mqV$G4Hq(#EX(oV z*hcele)_7r7mGfo0zhOP0JslGgE#6|jenvfSM=+`ITTCf{Z7-OX|SvUf^cvNv_Fu# zi>Af&F`WSsX5~RBVF4Bxv@>cfDY|Qy0?yMn`j`%Yy;kCX@6!UMFCR||FuFDX)F}o} zNLYaW);Id-$_6i$sL&oeu(Z?PVE;n4S>O8VROm~@zK>8U{Tk~iNSsnFwjadl;0Wb?_!dKScF?nvMtP`vINFT)8(qNEGY(mOPGOT zO^jxVz2}{wOINZbZf{=^vo~8DZaJqe+Frpjg`UV%Jsc^KGr%~KV^iB~K7T%!D0hne zxs~;c*i|(+w)h(%Tk(kv?vtnq{Ua>i?{{sOSPV{=0I}QoR1mtU!^$N6f})kMIOmr1 zmuL@VDd%T?D9!d#AIjBh?S1!Hm!+MAcs_IL>aIb)(3i?D+Bs{K>Z2}@m1m+>0jkR z$?yJVM>oJNG^mjC?gR3co=$T|h$Y0J+Ti@xj;pj70QJ2W;yo58NWq4N>ZfWwefQb$ zsg-q-Lhg&Sg*FioepV^~_0=|bge7J%I8g%BoX+cm5L-DZvEdQgM1R|c1ON(8*c$hH zs89K5{1MY2QU%)JfeX z0-!If!Z0i?kPCbu9)DIT(?$$I4R3lY*JM2)d&coM{4I414*>c=>|*6-X=~oS { - const frequentlyUsedEmojis = uniq((Cookies.get('frequently_used_emojis') || '').split(',')); + const frequentlyUsedEmojis = uniq((getCookie('frequently_used_emojis') || '').split(',')); this.frequentlyUsedEmojis = frequentlyUsedEmojis.filter((inputName) => this.emoji.isEmojiNameValid(inputName), ); diff --git a/app/assets/javascripts/behaviors/shortcuts/shortcuts.js b/app/assets/javascripts/behaviors/shortcuts/shortcuts.js index acb2355852d..9297b14aac9 100644 --- a/app/assets/javascripts/behaviors/shortcuts/shortcuts.js +++ b/app/assets/javascripts/behaviors/shortcuts/shortcuts.js @@ -1,9 +1,9 @@ import $ from 'jquery'; -import Cookies from 'js-cookie'; import { flatten } from 'lodash'; import Mousetrap from 'mousetrap'; import Vue from 'vue'; -import { parseBoolean } from '~/lib/utils/common_utils'; +import { getCookie, setCookie, parseBoolean } from '~/lib/utils/common_utils'; + import findAndFollowLink from '~/lib/utils/navigation_utility'; import { refreshCurrentPage, visitUrl } from '~/lib/utils/url_utility'; import { @@ -161,10 +161,10 @@ export default class Shortcuts { static onTogglePerfBar(e) { e.preventDefault(); const performanceBarCookieName = 'perf_bar_enabled'; - if (parseBoolean(Cookies.get(performanceBarCookieName))) { - Cookies.set(performanceBarCookieName, 'false', { expires: 365, path: '/' }); + if (parseBoolean(getCookie(performanceBarCookieName))) { + setCookie(performanceBarCookieName, 'false', { path: '/' }); } else { - Cookies.set(performanceBarCookieName, 'true', { expires: 365, path: '/' }); + setCookie(performanceBarCookieName, 'true', { path: '/' }); } refreshCurrentPage(); } @@ -172,8 +172,8 @@ export default class Shortcuts { static onToggleCanary(e) { e.preventDefault(); const canaryCookieName = 'gitlab_canary'; - const currentValue = parseBoolean(Cookies.get(canaryCookieName)); - Cookies.set(canaryCookieName, (!currentValue).toString(), { + const currentValue = parseBoolean(getCookie(canaryCookieName)); + setCookie(canaryCookieName, (!currentValue).toString(), { expires: 365, path: '/', // next.gitlab.com uses a leading period. See https://gitlab.com/gitlab-org/gitlab/-/issues/350186 diff --git a/app/assets/javascripts/blob/pipeline_tour_success_modal.vue b/app/assets/javascripts/blob/pipeline_tour_success_modal.vue index 47a0c4ba2d1..b4ca29114cb 100644 --- a/app/assets/javascripts/blob/pipeline_tour_success_modal.vue +++ b/app/assets/javascripts/blob/pipeline_tour_success_modal.vue @@ -1,6 +1,6 @@