kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Merge branch 'rename-local-variable' into 'master' 

Rename block scope local variable in table pagination spec

See merge request gitlab-org/gitlab-ce!21969
This commit is contained in:
Filipa Lacerda 2018-09-28 08:04:23 +00:00
parent bfa94a5fa2 7f395e862a
commit 71891664a1
2 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
changelogs/unreleased/rename-local-variable.yml Normal file
View File

@ -0,0 +1,5 @@
---
title: Rename block scope local variable in table pagination spec
merge_request: 21969
author: George Tsiolis
type: other

22
spec/javascripts/vue_shared/components/table_pagination_spec.js
View File

@ -5,13 +5,13 @@ describe('Pagination component', () => {
let component; let component;
let PaginationComponent; let PaginationComponent;
let spy; let spy;
let mountComponet; let mountComponent;
beforeEach(() => { beforeEach(() => {
spy = jasmine.createSpy('spy'); spy = jasmine.createSpy('spy');
PaginationComponent = Vue.extend(paginationComp); PaginationComponent = Vue.extend(paginationComp);
mountComponet = function (props) { mountComponent = function (props) {
return new PaginationComponent({ return new PaginationComponent({
propsData: props, propsData: props,
}).$mount(); }).$mount();
@ -20,7 +20,7 @@ describe('Pagination component', () => {
describe('render', () => { describe('render', () => {
it('should not render anything', () => { it('should not render anything', () => {
component = mountComponet({ component = mountComponent({
pageInfo: { pageInfo: {
nextPage: 1, nextPage: 1,
page: 1, page: 1,
@ -37,7 +37,7 @@ describe('Pagination component', () => {
describe('prev button', () => { describe('prev button', () => {
it('should be disabled and non clickable', () => { it('should be disabled and non clickable', () => {
component = mountComponet({ component = mountComponent({
pageInfo: { pageInfo: {
nextPage: 2, nextPage: 2,
page: 1, page: 1,
@ -59,7 +59,7 @@ describe('Pagination component', () => {
}); });
it('should be enabled and clickable', () => { it('should be enabled and clickable', () => {
component = mountComponet({ component = mountComponent({
pageInfo: { pageInfo: {
nextPage: 3, nextPage: 3,
page: 2, page: 2,
@ -78,7 +78,7 @@ describe('Pagination component', () => {
describe('first button', () => { describe('first button', () => {
it('should call the change callback with the first page', () => { it('should call the change callback with the first page', () => {
component = mountComponet({ component = mountComponent({
pageInfo: { pageInfo: {
nextPage: 3, nextPage: 3,
page: 2, page: 2,
@ -102,7 +102,7 @@ describe('Pagination component', () => {
describe('last button', () => { describe('last button', () => {
it('should call the change callback with the last page', () => { it('should call the change callback with the last page', () => {
component = mountComponet({ component = mountComponent({
pageInfo: { pageInfo: {
nextPage: 3, nextPage: 3,
page: 2, page: 2,
@ -126,7 +126,7 @@ describe('Pagination component', () => {
describe('next button', () => { describe('next button', () => {
it('should be disabled and non clickable', () => { it('should be disabled and non clickable', () => {
component = mountComponet({ component = mountComponent({
pageInfo: { pageInfo: {
nextPage: 5, nextPage: 5,
page: 5, page: 5,
@ -148,7 +148,7 @@ describe('Pagination component', () => {
}); });
it('should be enabled and clickable', () => { it('should be enabled and clickable', () => {
component = mountComponet({ component = mountComponent({
pageInfo: { pageInfo: {
nextPage: 4, nextPage: 4,
page: 3, page: 3,
@ -168,7 +168,7 @@ describe('Pagination component', () => {
describe('numbered buttons', () => { describe('numbered buttons', () => {
it('should render 5 pages', () => { it('should render 5 pages', () => {
component = mountComponet({ component = mountComponent({
pageInfo: { pageInfo: {
nextPage: 4, nextPage: 4,
page: 3, page: 3,
@ -185,7 +185,7 @@ describe('Pagination component', () => {
}); });
it('should render the spread operator', () => { it('should render the spread operator', () => {
component = mountComponet({ component = mountComponent({
pageInfo: { pageInfo: {
nextPage: 4, nextPage: 4,
page: 3, page: 3,