Remove unnecessary require_relative calls from service classes
Rails by default use autoload for all dirs from app folder. require_relative not needed. See ActiveSupport::Dependencies.autoload_paths
This commit is contained in:
parent
78e34d8add
commit
724864eeb4
|
@ -1,5 +1,3 @@
|
|||
require_relative 'base_service'
|
||||
|
||||
##
|
||||
# Branch can be deleted either by DeleteBranchService
|
||||
# or by GitPushService.
|
||||
|
|
|
@ -1,5 +1,3 @@
|
|||
require_relative 'base_service'
|
||||
|
||||
class CreateBranchService < BaseService
|
||||
def execute(branch_name, ref, source_project: @project)
|
||||
valid_branch = Gitlab::GitRefValidator.validate(branch_name)
|
||||
|
|
|
@ -1,5 +1,3 @@
|
|||
require_relative 'base_service'
|
||||
|
||||
class CreateDeploymentService < BaseService
|
||||
def execute(deployable = nil)
|
||||
return unless executable?
|
||||
|
|
|
@ -1,5 +1,3 @@
|
|||
require_relative 'base_service'
|
||||
|
||||
class CreateReleaseService < BaseService
|
||||
def execute(tag_name, release_description)
|
||||
repository = project.repository
|
||||
|
|
|
@ -1,5 +1,3 @@
|
|||
require_relative 'base_service'
|
||||
|
||||
class CreateTagService < BaseService
|
||||
def execute(tag_name, target, message, release_description = nil)
|
||||
valid_tag = Gitlab::GitRefValidator.validate(tag_name)
|
||||
|
|
|
@ -1,5 +1,3 @@
|
|||
require_relative 'base_service'
|
||||
|
||||
class DeleteBranchService < BaseService
|
||||
def execute(branch_name)
|
||||
repository = project.repository
|
||||
|
|
|
@ -1,5 +1,3 @@
|
|||
require_relative 'base_service'
|
||||
|
||||
class DeleteMergedBranchesService < BaseService
|
||||
def async_execute
|
||||
DeleteMergedBranchesWorker.perform_async(project.id, current_user.id)
|
||||
|
|
|
@ -1,5 +1,3 @@
|
|||
require_relative 'base_service'
|
||||
|
||||
class DeleteTagService < BaseService
|
||||
def execute(tag_name)
|
||||
repository = project.repository
|
||||
|
|
|
@ -1,5 +1,3 @@
|
|||
require_relative "base_service"
|
||||
|
||||
module Files
|
||||
class CreateDirService < Files::BaseService
|
||||
def commit
|
||||
|
|
|
@ -1,5 +1,3 @@
|
|||
require_relative "base_service"
|
||||
|
||||
module Files
|
||||
class CreateService < Files::BaseService
|
||||
def commit
|
||||
|
|
|
@ -1,5 +1,3 @@
|
|||
require_relative "base_service"
|
||||
|
||||
module Files
|
||||
class DeleteService < Files::BaseService
|
||||
def commit
|
||||
|
|
|
@ -1,5 +1,3 @@
|
|||
require_relative "base_service"
|
||||
|
||||
module Files
|
||||
class MultiService < Files::BaseService
|
||||
class FileChangedError < StandardError; end
|
||||
|
|
|
@ -1,5 +1,3 @@
|
|||
require_relative "base_service"
|
||||
|
||||
module Files
|
||||
class UpdateService < Files::BaseService
|
||||
class FileChangedError < StandardError; end
|
||||
|
|
|
@ -1,7 +1,3 @@
|
|||
require_relative 'base_service'
|
||||
require_relative 'reopen_service'
|
||||
require_relative 'close_service'
|
||||
|
||||
module MergeRequests
|
||||
class UpdateService < MergeRequests::BaseService
|
||||
def execute(merge_request)
|
||||
|
|
|
@ -1,5 +1,3 @@
|
|||
require_relative 'base_service'
|
||||
|
||||
class UpdateReleaseService < BaseService
|
||||
def execute(tag_name, release_description)
|
||||
repository = project.repository
|
||||
|
|
|
@ -0,0 +1,4 @@
|
|||
---
|
||||
title: 'Remove unnecessary require_relative calls from service classes'
|
||||
merge_request: '7601'
|
||||
author: Semyon Pupkov
|
Loading…
Reference in New Issue