From 73507eaf1a77c5c05ae17c9f7ac29bbeb8bf5be1 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 25 Aug 2022 12:12:20 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop.yml | 3 - .rubocop_todo/style/float_division.yml | 8 + .../blob/notebook/notebook_viewer.vue | 4 +- .../components/ci_admin_variables.vue | 4 +- .../components/ci_group_variables.vue | 4 +- .../components/ci_project_variables.vue | 4 +- .../components/ci_variable_modal.vue | 14 +- .../javascripts/ci_variable_list/constants.js | 10 +- app/assets/javascripts/crm/constants.js | 4 + .../javascripts/crm/organizations/bundle.js | 18 +- .../get_group_organizations.query.graphql | 29 ++- ...organizations_count_by_state.query.graphql | 11 + .../components/organization_form_wrapper.vue | 2 +- .../components/organizations_root.vue | 225 +++++++++++++----- .../deploy_keys/components/key.vue | 4 +- .../deploy_keys/components/keys_panel.vue | 4 +- app/assets/javascripts/deploy_keys/index.js | 4 +- .../diffs/components/diff_content.vue | 4 +- .../diffs/components/diff_discussions.vue | 4 +- .../diffs/components/diff_line_note_form.vue | 4 +- app/assets/javascripts/diffs/index.js | 4 +- .../environments/components/deploy_board.vue | 4 +- .../folder/environments_folder_bundle.js | 4 +- .../groups/components/group_item.vue | 16 +- .../groups/components/item_stats.vue | 8 +- app/assets/javascripts/groups/index.js | 12 +- .../javascripts/header_search/constants.js | 25 +- .../header_search/store/actions.js | 29 ++- .../header_search/store/getters.js | 18 +- .../header_search/store/mutations.js | 8 +- .../ide/components/ide_status_bar.vue | 4 +- .../ide/components/new_dropdown/index.vue | 4 +- .../issues/show/components/app.vue | 16 +- .../issues/show/components/edited.vue | 4 +- .../show/components/fields/description.vue | 4 +- .../jobs/components/stages_dropdown.vue | 4 +- .../javascripts/linked_resources/index.js | 2 +- app/assets/javascripts/mr_notes/index.js | 4 +- app/assets/javascripts/mr_notes/init_notes.js | 4 +- .../javascripts/notebook/cells/markdown.vue | 2 +- .../notebook/cells/output/image.vue | 2 +- .../notes/components/comment_form.vue | 12 +- .../components/diff_discussion_header.vue | 8 +- .../notes/components/note_body.vue | 16 +- .../notes/components/note_edited_text.vue | 4 +- .../notes/components/note_form.vue | 4 +- .../notes/components/note_header.vue | 4 +- .../notes/components/noteable_discussion.vue | 20 +- .../notes/components/noteable_note.vue | 8 +- .../notes/components/notes_app.vue | 36 +-- app/assets/javascripts/notes/index.js | 4 +- .../details/installation_commands.vue | 19 +- .../pages/admin/jobs/index/index.js | 4 +- .../pages/projects/blob/show/index.js | 4 +- .../pipeline_schedules/shared/init_form.js | 4 +- .../permissions/components/settings_panel.vue | 10 +- app/assets/javascripts/pdf/index.vue | 4 +- .../pipelines/components/header_component.vue | 4 +- .../jobs_shared/job_name_component.vue | 4 +- .../components/pipeline_graph/job_pill.vue | 4 +- .../components/pipeline_graph/stage_name.vue | 4 +- .../pipelines/pipeline_details_header.js | 4 +- .../javascripts/profile/account/index.js | 4 +- .../commit_pipeline_status_component.vue | 4 +- .../components/related_issuable_input.vue | 4 +- .../components/related_issues_root.vue | 2 +- .../sidebar/components/lock/edit_form.vue | 4 +- .../components/lock/issuable_lock_form.vue | 4 +- .../components/participants/participants.vue | 4 +- .../sidebar/mount_milestone_sidebar.js | 6 +- .../surveys/merge_request_experience/app.vue | 15 +- .../components/extensions/telemetry.js | 2 +- .../components/mr_widget_status_icon.vue | 4 +- .../components/states/mr_widget_archived.vue | 4 +- .../components/states/mr_widget_checking.vue | 4 +- .../components/states/mr_widget_closed.vue | 4 +- .../states/mr_widget_failed_to_merge.vue | 4 +- .../components/states/mr_widget_merging.vue | 4 +- .../states/mr_widget_missing_branch.vue | 4 +- .../components/states/pipeline_failed.vue | 4 +- .../mr_widget_options.vue | 38 +-- .../components/notes/system_note.vue | 4 +- .../components/work_item_links/index.js | 2 +- app/finders/merge_requests_finder.rb | 10 +- app/finders/merge_requests_finder/params.rb | 6 - .../concerns/merge_request_reviewer_state.rb | 12 +- app/models/group.rb | 8 +- app/models/merge_request.rb | 11 - app/models/merge_request_assignee.rb | 4 +- app/models/user.rb | 4 - app/models/users/callout.rb | 3 +- app/serializers/merge_request_user_entity.rb | 12 +- app/services/merge_requests/base_service.rb | 43 ---- .../update_assignees_service.rb | 2 - .../groups/crm/organizations/index.html.haml | 2 +- app/workers/all_queues.yml | 9 + ...o_factor_requirement_for_members_worker.rb | 22 ++ .../development/mr_attention_requests.yml | 8 - config/sidekiq_queues.yml | 2 + doc/api/graphql/reference/index.md | 3 - doc/api/merge_requests.md | 16 -- .../documentation/styleguide/word_list.md | 2 +- doc/user/analytics/code_review_analytics.md | 55 ++--- .../img/code_review_analytics_v13_11.png | Bin 37179 -> 0 bytes doc/user/project/milestones/index.md | 98 ++++---- lib/api/entities/merge_request_reviewer.rb | 1 - .../ci/build/rules/rule/clause/exists.rb | 2 +- lib/gitlab/gon_helper.rb | 1 - locale/gitlab.pot | 18 ++ package.json | 2 +- qa/qa/support/api.rb | 20 +- .../merge_requests_finder/params_spec.rb | 23 -- spec/finders/merge_requests_finder_spec.rb | 19 -- .../gitlab/import_export/complex/project.json | 4 +- .../tree/project/merge_requests.ndjson | 2 +- .../components/ci_variable_modal_spec.js | 17 ++ spec/frontend/ci_variable_list/mocks.js | 6 +- spec/frontend/crm/mock_data.js | 22 ++ spec/frontend/crm/organizations_root_spec.js | 92 +++++-- spec/frontend/header_search/mock_data.js | 44 ++-- .../header_search/store/actions_spec.js | 66 ++++- .../header_search/store/getters_spec.js | 24 -- .../commit_sidebar/radio_group_spec.js | 8 +- .../merge_request_performance/app_spec.js | 38 ++- .../mr_widget_options_spec.js | 2 +- .../merge_request_review_state_enum_spec.rb | 4 - ...ser_merge_request_interaction_type_spec.rb | 3 - .../ci/build/rules/rule/clause/exists_spec.rb | 52 ++-- .../ci/config/external/file/remote_spec.rb | 39 +++ .../ci/config/external/processor_spec.rb | 30 +++ spec/lib/gitlab/import_export/all_models.yml | 2 - .../gitlab/utils/delegator_override_spec.rb | 1 + spec/lib/gitlab/utils/nokogiri_spec.rb | 3 +- .../gitlab/utils/sanitize_node_link_spec.rb | 4 +- spec/models/group_spec.rb | 101 ++++---- spec/models/merge_request_assignee_spec.rb | 22 -- spec/models/merge_request_reviewer_spec.rb | 20 -- spec/models/merge_request_spec.rb | 16 -- spec/models/user_spec.rb | 19 -- .../users/merge_request_interaction_spec.rb | 3 - .../api/graphql/project/merge_request_spec.rb | 20 +- spec/requests/api/merge_requests_spec.rb | 1 - .../update_assignees_service_spec.rb | 43 ---- .../merge_requests/update_service_spec.rb | 98 -------- .../support/helpers/javascript_form_helper.rb | 7 + spec/support/rspec_order_todo.yml | 22 -- ...sallow_two_factor_for_group_worker_spec.rb | 2 +- ...tor_requirement_for_members_worker_spec.rb | 39 +++ workhorse/internal/headers/content_headers.go | 4 + .../contentprocessor/contentprocessor_test.go | 18 +- workhorse/internal/upstream/routes.go | 3 + workhorse/testdata/file.docx | Bin 0 -> 6151 bytes workhorse/upload_test.go | 2 + yarn.lock | 8 +- 154 files changed, 1160 insertions(+), 1017 deletions(-) create mode 100644 .rubocop_todo/style/float_division.yml create mode 100644 app/assets/javascripts/crm/organizations/components/graphql/get_group_organizations_count_by_state.query.graphql create mode 100644 app/workers/groups/update_two_factor_requirement_for_members_worker.rb delete mode 100644 config/feature_flags/development/mr_attention_requests.yml delete mode 100644 doc/user/analytics/img/code_review_analytics_v13_11.png delete mode 100644 spec/finders/merge_requests_finder/params_spec.rb create mode 100644 spec/support/helpers/javascript_form_helper.rb create mode 100644 spec/workers/groups/update_two_factor_requirement_for_members_worker_spec.rb create mode 100644 workhorse/testdata/file.docx diff --git a/.rubocop.yml b/.rubocop.yml index 43b4e46171b..86549bc84d2 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -602,9 +602,6 @@ Style/MultilineWhenThen: Style/NumericPredicate: EnforcedStyle: comparison -Style/FloatDivision: - Enabled: false - Cop/BanCatchThrow: Enabled: true diff --git a/.rubocop_todo/style/float_division.yml b/.rubocop_todo/style/float_division.yml new file mode 100644 index 00000000000..201f89ac35a --- /dev/null +++ b/.rubocop_todo/style/float_division.yml @@ -0,0 +1,8 @@ +--- +Style/FloatDivision: + Exclude: + - 'ee/app/models/geo_node_status.rb' + - 'ee/app/models/namespaces/storage/root_size.rb' + - 'lib/learn_gitlab/onboarding.rb' + - 'qa/qa/support/formatters/allure_metadata_formatter.rb' + - 'qa/qa/tools/reliable_report.rb' diff --git a/app/assets/javascripts/blob/notebook/notebook_viewer.vue b/app/assets/javascripts/blob/notebook/notebook_viewer.vue index 79b8d273883..dc1a9cb865a 100644 --- a/app/assets/javascripts/blob/notebook/notebook_viewer.vue +++ b/app/assets/javascripts/blob/notebook/notebook_viewer.vue @@ -1,11 +1,11 @@ @@ -298,16 +298,20 @@ export default { /> -
- +
+ - +