kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Use switch statements instead of if/else chains.

Browse source
This commit is contained in:
Connor Shea 2016-07-15 14:08:27 -06:00
parent b2a79554c3
commit 737e5226f8
No known key found for this signature in database
GPG key ID: E52237E5B35A83E6
2 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/assets/javascripts/merge_request_widget.js.coffee
View file

@ -55,9 +55,10 @@ class @MergeRequestWidget
$('.mr-state-widget').replaceWith(data)
ciLabelForStatus: (status) ->
if status is 'success'
switch status
when 'success'
'passed'
else if status is 'success_with_warnings'
when 'success_with_warnings'
'passed with warnings'
else
status

5
app/helpers/ci_status_helper.rb
View file

@ -15,9 +15,10 @@ module CiStatusHelper
end
def ci_label_for_status(status)
if status == 'success'
case status
when 'success'
'passed'
elsif status == 'success_with_warnings'
when 'success_with_warnings'
'passed with warnings'
else
status