kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Refactor ci commit specs by adding context blocks

Browse source
This commit is contained in:
Grzegorz Bizon 2016-04-19 12:36:57 +02:00
parent bdb86ea6cf
commit 7518330aa1
1 changed files with 77 additions and 69 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
spec/models/ci/commit_spec.rb
View file

@ -158,6 +158,7 @@ describe Ci::Commit, models: true do
stub_ci_commit_yaml_file(YAML.dump(yaml)) stub_ci_commit_yaml_file(YAML.dump(yaml))
end end
context 'when builds are successful' do
it 'properly creates builds' do it 'properly creates builds' do
expect(create_builds).to be_truthy expect(create_builds).to be_truthy
expect(commit.builds.pluck(:name)).to contain_exactly('build') expect(commit.builds.pluck(:name)).to contain_exactly('build')
@ -180,8 +181,10 @@ describe Ci::Commit, models: true do
commit.reload commit.reload
expect(commit.status).to eq('success') expect(commit.status).to eq('success')
end end
end
it 'properly creates builds when test fails' do context 'when test job fails' do
it 'properly creates builds' do
expect(create_builds).to be_truthy expect(create_builds).to be_truthy
expect(commit.builds.pluck(:name)).to contain_exactly('build') expect(commit.builds.pluck(:name)).to contain_exactly('build')
expect(commit.builds.pluck(:status)).to contain_exactly('pending') expect(commit.builds.pluck(:status)).to contain_exactly('pending')
@ -203,8 +206,10 @@ describe Ci::Commit, models: true do
commit.reload commit.reload
expect(commit.status).to eq('failed') expect(commit.status).to eq('failed')
end end
end
it 'properly creates builds when test and test_failure fails' do context 'when test and test_failure jobs fail' do
it 'properly creates builds' do
expect(create_builds).to be_truthy expect(create_builds).to be_truthy
expect(commit.builds.pluck(:name)).to contain_exactly('build') expect(commit.builds.pluck(:name)).to contain_exactly('build')
expect(commit.builds.pluck(:status)).to contain_exactly('pending') expect(commit.builds.pluck(:status)).to contain_exactly('pending')
@ -227,8 +232,10 @@ describe Ci::Commit, models: true do
commit.reload commit.reload
expect(commit.status).to eq('failed') expect(commit.status).to eq('failed')
end end
end
it 'properly creates builds when deploy fails' do context 'when deploy job fails' do
it 'properly creates builds' do
expect(create_builds).to be_truthy expect(create_builds).to be_truthy
expect(commit.builds.pluck(:name)).to contain_exactly('build') expect(commit.builds.pluck(:name)).to contain_exactly('build')
expect(commit.builds.pluck(:status)).to contain_exactly('pending') expect(commit.builds.pluck(:status)).to contain_exactly('pending')
@ -252,6 +259,7 @@ describe Ci::Commit, models: true do
end end
end end
end end
end
describe "#finished_at" do describe "#finished_at" do
let(:commit) { FactoryGirl.create :ci_commit } let(:commit) { FactoryGirl.create :ci_commit }