Use the same standard for method names on project activity and menu

... page objects.

Also, update the affected test case.

I choose `click_...` instead of `go_to_...` since it describes
better what the method really does, which is clicking on something.

I know there are other places in the code where methods start with
`click_` and others where methods start with `go_to_`, with that
I'd like to start a discussion or be pointed to the right issue if
there is already one so that we can address this in the whole
framework.
This contribution could be the start in the direction of using the
standard chosen here.
This commit is contained in:
Walmyr 2019-03-18 15:18:06 +00:00 committed by Mark Lapierre
parent f012e93482
commit 7561241525
3 changed files with 4 additions and 4 deletions

View File

@ -6,7 +6,7 @@ module QA
element :push_events, "event_filter_link EventFilter::PUSH, _('Push events')" # rubocop:disable QA/ElementWithPattern
end
def go_to_push_events
def click_push_events
click_on 'Push events'
end
end

View File

@ -30,7 +30,7 @@ module QA
end
end
def go_to_activity
def click_activity
within_sidebar do
click_element(:activity_link)
end

View File

@ -14,8 +14,8 @@ module QA
end
project_push.project.visit!
Page::Project::Menu.perform(&:go_to_activity)
Page::Project::Activity.perform(&:go_to_push_events)
Page::Project::Menu.perform(&:click_activity)
Page::Project::Activity.perform(&:click_push_events)
expect(page).to have_content('pushed new branch master')
end