From 77ca4a675ac7f8684f0b7c10592140365fc13a2d Mon Sep 17 00:00:00 2001 From: Alfredo Sumaran Date: Wed, 18 May 2016 20:23:00 -0500 Subject: [PATCH] Make conditional a guard clause --- app/helpers/todos_helper.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/helpers/todos_helper.rb b/app/helpers/todos_helper.rb index 27f33b3eded..b9d7edb4185 100644 --- a/app/helpers/todos_helper.rb +++ b/app/helpers/todos_helper.rb @@ -38,11 +38,11 @@ module TodosHelper end def todo_target_state_pill(todo) - if show_todo_state?(todo) - content_tag(:span, nil, class: 'target-status') do - content_tag(:span, nil, class: "status-box status-box-#{todo.target.state.dasherize}") do - todo.target.state.capitalize - end + return unless show_todo_state?(todo) + + content_tag(:span, nil, class: 'target-status') do + content_tag(:span, nil, class: "status-box status-box-#{todo.target.state.dasherize}") do + todo.target.state.capitalize end end end