kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Clean up the show_spec examples previously added

Browse source
This commit is contained in:
Fabio Papa 2019-07-01 09:17:26 -07:00
parent 42167779ea
commit 7848c4daee
1 changed files with 18 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
spec/features/groups/show_spec.rb
View file

@ -56,27 +56,28 @@ describe 'Group show page' do
end
context 'subgroup support' do
let(:restricted_group) { create(:group,
subgroup_creation_level: ::Gitlab::Access::OWNER_SUBGROUP_ACCESS) }
let(:relaxed_group) { create(:group,
subgroup_creation_level: ::Gitlab::Access::MAINTAINER_SUBGROUP_ACCESS) }
let(:owner) { create(:user) }
let(:maintainer) { create(:user) }
before do
group.add_owner(owner)
group.add_maintainer(maintainer)
end
context 'for owners' do
let(:path) { group_path(restricted_group) }
before do
restricted_group.add_owner(owner)
sign_in(owner)
end
context 'when subgroups are supported', :js, :nested_groups do
before do
allow(Group).to receive(:supports_nested_objects?) { true }
visit path
end
it 'allows creating subgroups' do
visit path
expect(page)
.to have_css("li[data-text='New subgroup']", visible: false)
end
@ -85,11 +86,10 @@ describe 'Group show page' do
context 'when subgroups are not supported' do
before do
allow(Group).to receive(:supports_nested_objects?) { false }
visit path
end
it 'does not allow creating subgroups' do
visit path
expect(page)
.not_to have_selector("li[data-text='New subgroup']", visible: false)
end
@ -107,30 +107,30 @@ describe 'Group show page' do
end
context 'when subgroup_creation_level is set to maintainers' do
let(:group) do
create(:group,
subgroup_creation_level: ::Gitlab::Access::MAINTAINER_SUBGROUP_ACCESS)
before do
relaxed_group.add_maintainer(maintainer)
path = group_path(relaxed_group)
visit path
end
it 'allows creating subgroups' do
visit path
expect(page)
.to have_css("li[data-text='New subgroup']", visible: false)
end
end
context 'when subgroup_creation_level is set to owners' do
let(:group) do
create(:group,
subgroup_creation_level: ::Gitlab::Access::OWNER_SUBGROUP_ACCESS)
before do
restricted_group.add_maintainer(maintainer)
end
it 'does not allow creating subgroups' do
path = group_path(restricted_group)
visit path
expect(page)
.not_to have_css("li[data-text='New subgroup']", visible: false)
.not_to have_selector("li[data-text='New subgroup']",
visible: false)
end
end
end