Refactor: grouping parent and their space by including array.

This commit is contained in:
Sato Hiroyuki 2013-03-06 21:01:40 +09:00
parent 2f7f46b256
commit 784aa266bd
3 changed files with 7 additions and 5 deletions

View file

@ -117,7 +117,7 @@
// Draw lines
for (var j = 0, jj = this.commits[i].parents.length; j < jj; j++) {
c = this.preparedCommits[this.commits[i].parents[j][0]];
ps = this.commits[i].parent_spaces[j];
ps = this.commits[i].parents[j][1];
if (c) {
var cx = offsetX + 20 * c.time
, cy = offsetY + 10 * c.space

View file

@ -2,4 +2,9 @@ module GraphHelper
def join_with_space(ary)
ary.collect{|r|r.name}.join(" ") unless ary.nil?
end
def parents_zip_spaces(parents, parent_spaces)
ids = parents.map { |p| p.id }
ids.zip(parent_spaces)
end
end

View file

@ -5,9 +5,7 @@
days: @graph.days.compact.map { |d| [d.day, d.strftime("%b")] },
commits: @graph.commits.map do |c|
{
parents: c.parents.collect do |p|
[p.id,0,0]
end,
parents: parents_zip_spaces(c.parents, c.parent_spaces),
author: {
name: c.author.name,
email: c.author.email,
@ -15,7 +13,6 @@
},
time: c.time,
space: c.spaces.first,
parent_spaces: c.parent_spaces,
refs: join_with_space(c.refs),
id: c.sha,
date: c.date,