kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

describe #closes_issues and describe # #issues_mentioned_but_not_closing on merge_request_spec.rb

Browse source
This commit is contained in:
Gabriel Gizotti 2016-11-28 19:02:37 +10:00
parent d1980ef9c8
commit 78f221d12e
1 changed files with 16 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
spec/models/merge_request_spec.rb
View file

@ -252,7 +252,7 @@ describe MergeRequest, models: true do
end end
end end
describe 'detection of issues' do describe '#closes_issues' do
let(:issue0) { create :issue, project: subject.project } let(:issue0) { create :issue, project: subject.project }
let(:issue1) { create :issue, project: subject.project } let(:issue1) { create :issue, project: subject.project }
@ -265,7 +265,6 @@ describe MergeRequest, models: true do
allow(subject).to receive(:commits).and_return([commit0, commit1, commit2]) allow(subject).to receive(:commits).and_return([commit0, commit1, commit2])
end end
describe 'detection of issues to be closed' do
it 'accesses the set of issues that will be closed on acceptance' do it 'accesses the set of issues that will be closed on acceptance' do
allow(subject.project).to receive(:default_branch). allow(subject.project).to receive(:default_branch).
and_return(subject.target_branch) and_return(subject.target_branch)
@ -281,22 +280,13 @@ describe MergeRequest, models: true do
expect(subject.closes_issues).to be_empty expect(subject.closes_issues).to be_empty
end end
it 'detects issues mentioned in the description' do
issue2 = create(:issue, project: subject.project)
subject.description = "Closes #{issue2.to_reference}"
allow(subject.project).to receive(:default_branch).
and_return(subject.target_branch)
expect(subject.closes_issues).to include(issue2)
end
end end
describe '#issues_mentioned_but_not_closing' do
it 'detects issues mentioned in description but not closed' do it 'detects issues mentioned in description but not closed' do
mentioned_issue = create(:issue, project: subject.project) mentioned_issue = create(:issue, project: subject.project)
subject.project.team << [subject.author, :developer]
subject.description = "Is related to #{mentioned_issue.to_reference}" subject.description = "Is related to #{mentioned_issue.to_reference}"
allow(subject.project).to receive(:default_branch). allow(subject.project).to receive(:default_branch).