diff --git a/Gemfile b/Gemfile index ad032aa0119..48532492653 100644 --- a/Gemfile +++ b/Gemfile @@ -129,7 +129,7 @@ gem 'apollo_upload_server', '~> 2.1.0' gem 'graphql-docs', '~> 2.1.0', group: [:development, :test] gem 'graphlient', '~> 0.5.0' # Used by BulkImport feature (group::import) -gem 'hashie' +gem 'hashie', '~> 5.0.0' # Disable strong_params so that Mash does not respond to :permitted? gem 'hashie-forbidden_attributes' diff --git a/Gemfile.checksum b/Gemfile.checksum index 74500a24d73..50463fe2715 100644 --- a/Gemfile.checksum +++ b/Gemfile.checksum @@ -259,7 +259,7 @@ {"name":"hana","version":"1.3.7","platform":"ruby","checksum":"5425db42d651fea08859811c29d20446f16af196308162894db208cac5ce9b0d"}, {"name":"hangouts-chat","version":"0.0.5","platform":"ruby","checksum":"bdbeb6c6e4abc98f395cb273f53b39911b3aa9e248fbbf063242b021ced8b6b6"}, {"name":"hashdiff","version":"1.0.1","platform":"ruby","checksum":"2cd4d04f5080314ecc8403c4e2e00dbaa282dff395e2d031bc16c8d501bdd6db"}, -{"name":"hashie","version":"4.1.0","platform":"ruby","checksum":"7890dcb9ec18a4b66acec797018c73824b89cef5eb8cda36e8e8501845e87a09"}, +{"name":"hashie","version":"5.0.0","platform":"ruby","checksum":"9d6c4e51f2a36d4616cbc8a322d619a162d8f42815a792596039fc95595603da"}, {"name":"hashie-forbidden_attributes","version":"0.1.1","platform":"ruby","checksum":"3a6ed37f3a314e4fb1dd1e2df6eb7721bcadd023a30bc0b951b2b5285a790fb2"}, {"name":"health_check","version":"3.1.0","platform":"ruby","checksum":"10146508237dc54ed7e24c292d8ba7fb8f9590cf26c66e325b947438c4103b57"}, {"name":"heapy","version":"0.2.0","platform":"ruby","checksum":"74141e845d61ffc7c1e8bf8b127c8cf94544ec7a1181aec613288682543585ea"}, diff --git a/Gemfile.lock b/Gemfile.lock index 8d2b983cf00..dc1a39776bc 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -709,7 +709,7 @@ GEM hana (1.3.7) hangouts-chat (0.0.5) hashdiff (1.0.1) - hashie (4.1.0) + hashie (5.0.0) hashie-forbidden_attributes (0.1.1) hashie (>= 3.0) health_check (3.1.0) @@ -1661,7 +1661,7 @@ DEPENDENCIES haml_lint (~> 0.40.0) hamlit (~> 2.15.0) hangouts-chat (~> 0.0.5) - hashie + hashie (~> 5.0.0) hashie-forbidden_attributes health_check (~> 3.0) html-pipeline (~> 2.13.2) diff --git a/app/assets/javascripts/deploy_tokens/components/new_deploy_token.vue b/app/assets/javascripts/deploy_tokens/components/new_deploy_token.vue index 639dd21bd7b..b585b6f9579 100644 --- a/app/assets/javascripts/deploy_tokens/components/new_deploy_token.vue +++ b/app/assets/javascripts/deploy_tokens/components/new_deploy_token.vue @@ -109,10 +109,11 @@ export default { writePackageRegistryHelp: s__( 'DeployTokens|Allows read and write access to the package registry.', ), + createTokenFailedAlert: s__('DeployTokens|Failed to create a new deployment token'), }, computed: { formattedExpiryDate() { - return formatDate(this.expiresAt, 'yyyy-mm-dd'); + return this.expiresAt ? formatDate(this.expiresAt, 'yyyy-mm-dd') : ''; }, newTokenCreatedMessage() { return this.tokenType === 'group' @@ -129,6 +130,9 @@ export default { name: this.name, read_repository: this.readRepository, read_registry: this.readRegistry, + write_registry: this.writeRegistry, + read_package_registry: this.readPackageRegistry, + write_package_registry: this.writePackageRegistry, username: this.username, }, }) @@ -142,7 +146,8 @@ export default { }) .catch((error) => { createAlert({ - message: error.response.data.message, + message: + error?.response?.data?.message || this.$options.translations.createTokenFailedAlert, }); }); }, diff --git a/app/assets/javascripts/vue_merge_request_widget/components/deployment/deployment_info.vue b/app/assets/javascripts/vue_merge_request_widget/components/deployment/deployment_info.vue index 30098f7619a..2132c2953d9 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/deployment/deployment_info.vue +++ b/app/assets/javascripts/vue_merge_request_widget/components/deployment/deployment_info.vue @@ -1,7 +1,6 @@