Fix projects_limit RangeError on user create
This commit is contained in:
parent
f74e9245cb
commit
7a1236031a
|
@ -115,7 +115,9 @@ class User < ActiveRecord::Base
|
|||
validates :notification_email, email: true, if: ->(user) { user.notification_email != user.email }
|
||||
validates :public_email, presence: true, uniqueness: true, email: true, allow_blank: true
|
||||
validates :bio, length: { maximum: 255 }, allow_blank: true
|
||||
validates :projects_limit, presence: true, numericality: { greater_than_or_equal_to: 0 }
|
||||
validates :projects_limit,
|
||||
presence: true,
|
||||
numericality: { greater_than_or_equal_to: 0, less_than_or_equal_to: Gitlab::Database::MAX_INT_VALUE }
|
||||
validates :username,
|
||||
namespace: true,
|
||||
presence: true,
|
||||
|
|
|
@ -2,7 +2,7 @@
|
|||
%legend Access
|
||||
.form-group
|
||||
= f.label :projects_limit, class: 'control-label'
|
||||
.col-sm-10= f.number_field :projects_limit, min: 0, class: 'form-control'
|
||||
.col-sm-10= f.number_field :projects_limit, min: 0, max: Gitlab::Database::MAX_INT_VALUE, class: 'form-control'
|
||||
|
||||
.form-group
|
||||
= f.label :can_create_group, class: 'control-label'
|
||||
|
|
|
@ -0,0 +1,4 @@
|
|||
---
|
||||
title: Fix projects_limit RangeError on user create
|
||||
merge_request:
|
||||
author: Alexander Randa
|
|
@ -81,6 +81,7 @@ describe User, models: true do
|
|||
it { is_expected.to validate_numericality_of(:projects_limit) }
|
||||
it { is_expected.to allow_value(0).for(:projects_limit) }
|
||||
it { is_expected.not_to allow_value(-1).for(:projects_limit) }
|
||||
it { is_expected.not_to allow_value(Gitlab::Database::MAX_INT_VALUE + 1).for(:projects_limit) }
|
||||
|
||||
it { is_expected.to validate_length_of(:bio).is_at_most(255) }
|
||||
|
||||
|
|
Loading…
Reference in New Issue