kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Use nil for non-existing files rather than 0

Browse source
This commit is contained in:
Lin Jen-Shin 2016-07-01 00:00:35 +08:00
parent 9d8dca08e4
commit 7b06acea1c
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/models/ci/build.rb
View file

@ -382,7 +382,9 @@ module Ci
private
def update_artifacts_size
self.artifacts_size = artifacts_file.size
self.artifacts_size = if artifacts_file.exists?
artifacts_file.size
end
end
def erase_trace!

2
spec/requests/ci/api/builds_spec.rb
View file

@ -486,7 +486,7 @@ describe Ci::API::API do
expect(response).to have_http_status(200)
expect(build.artifacts_file.exists?).to be_falsy
expect(build.artifacts_metadata.exists?).to be_falsy
expect(build.artifacts_size).to eq(0)
expect(build.artifacts_size).to be_nil
end
end