From 7bbc731c75d0b8bf7c74ba77d521266d2ed0a1fc Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 7 Jun 2022 15:08:12 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/static-analysis.gitlab-ci.yml | 38 --- .semgrepignore | 107 ------- GITALY_SERVER_VERSION | 2 +- .../components/new_access_token_app.vue | 16 +- .../components/lint/ci_lint_results.vue | 2 +- .../components/graph/linked_pipeline.vue | 2 +- .../registration/registration_dropdown.vue | 12 +- .../registration/registration_token.vue | 9 +- .../terraform/components/states_table.vue | 60 ++-- .../graphql/fragments/state.fragment.graphql | 1 + .../components/extensions/child_content.vue | 12 +- .../form/input_copy_toggle_visibility.vue | 53 ++-- .../runner_instructions.vue | 22 +- .../runner_instructions_modal.vue | 32 +- .../dropdown_contents.vue | 5 +- .../packages/cleanup/policy/update.rb | 48 +++ app/graphql/types/mutation_type.rb | 1 + .../keep_duplicated_package_files_enum.rb | 25 ++ .../types/packages/cleanup/policy_type.rb | 23 ++ app/graphql/types/project_type.rb | 5 + app/graphql/types/terraform/state_type.rb | 4 + app/models/packages/cleanup/policy.rb | 2 +- .../packages/cleanup/policy_policy.rb | 9 + app/policies/project_policy.rb | 1 + .../packages/cleanup/update_policy_service.rb | 35 +++ .../standard_context_type_check.yml | 8 + config/sidekiq_queues.yml | 2 + doc/api/graphql/reference/index.md | 45 +++ doc/user/free_user_limit.md | 2 +- lib/gitlab/tracking/standard_context.rb | 14 + locale/gitlab.pot | 8 +- .../1_manage/group/transfer_project_spec.rb | 5 +- rubocop/rubocop-migrations.yml | 41 ++- scripts/process_custom_semgrep_results.sh | 55 ---- .../profiles/personal_access_tokens_spec.rb | 2 +- .../components/new_access_token_app_spec.js | 25 +- .../registration_dropdown_spec.js | 11 +- .../terraform/components/states_table_spec.js | 40 ++- .../form/input_copy_toggle_visibility_spec.js | 85 ++--- .../runner_instructions_modal_spec.js | 294 +++++++++--------- .../runner_instructions_spec.js | 24 +- ...keep_duplicated_package_files_enum_spec.rb | 15 + .../packages/cleanup/policy_type_spec.rb | 26 ++ spec/graphql/types/project_type_spec.rb | 8 +- .../types/terraform/state_type_spec.rb | 3 +- .../gitlab/tracking/standard_context_spec.rb | 28 ++ spec/models/packages/cleanup/policy_spec.rb | 2 +- spec/policies/project_policy_spec.rb | 30 ++ .../packages/cleanup/policy/update_spec.rb | 109 +++++++ .../project/packages_cleanup_policy_spec.rb | 79 +++++ .../cleanup/update_policy_service_spec.rb | 105 +++++++ spec/support/helpers/next_instance_of.rb | 2 +- .../features/runners_shared_examples.rb | 4 +- ...esource_from_resource_group_worker_spec.rb | 2 +- 54 files changed, 1067 insertions(+), 533 deletions(-) delete mode 100644 .semgrepignore create mode 100644 app/graphql/mutations/packages/cleanup/policy/update.rb create mode 100644 app/graphql/types/packages/cleanup/keep_duplicated_package_files_enum.rb create mode 100644 app/graphql/types/packages/cleanup/policy_type.rb create mode 100644 app/policies/packages/cleanup/policy_policy.rb create mode 100644 app/services/packages/cleanup/update_policy_service.rb create mode 100644 config/feature_flags/development/standard_context_type_check.yml delete mode 100755 scripts/process_custom_semgrep_results.sh create mode 100644 spec/graphql/types/packages/cleanup/keep_duplicated_package_files_enum_spec.rb create mode 100644 spec/graphql/types/packages/cleanup/policy_type_spec.rb create mode 100644 spec/requests/api/graphql/mutations/packages/cleanup/policy/update_spec.rb create mode 100644 spec/requests/api/graphql/project/packages_cleanup_policy_spec.rb create mode 100644 spec/services/packages/cleanup/update_policy_service_spec.rb diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 95c0d93b2fc..e1257e778bd 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -152,41 +152,3 @@ feature-flags-usage: when: always paths: - tmp/feature_flags/ - -semgrep-appsec-custom-rules: - stage: lint - extends: - - .static-analysis:rules:ee - image: returntocorp/semgrep - needs: [] - script: - # Required to avoid a timeout https://github.com/returntocorp/semgrep/issues/5395 - - git fetch origin master - # Include/exclude list isn't ideal https://github.com/returntocorp/semgrep/issues/5399 - - | - semgrep ci --gitlab-sast --metrics off --config $CUSTOM_RULES_URL \ - --include app --include lib --include workhorse \ - --exclude '*_test.go' --exclude spec --exclude qa > gl-sast-report.json || true - variables: - CUSTOM_RULES_URL: https://gitlab.com/gitlab-com/gl-security/appsec/sast-custom-rules/-/raw/main/appsec-pings/rules.yml - artifacts: - paths: - - gl-sast-report.json - reports: - sast: gl-sast-report.json - -ping-appsec-for-sast-findings: - stage: lint - image: alpine:latest - variables: - # Project Access Token bot ID for /gitlab-com/gl-security/appsec/sast-custom-rules - BOT_USER_ID: 11727358 - needs: - - semgrep-appsec-custom-rules - rules: - # Requiring $CUSTOM_SAST_RULES_BOT_PAT prevents the bot from running on forks or CE - # Without it the script would fail too. - - if: "$CI_MERGE_REQUEST_IID && $CUSTOM_SAST_RULES_BOT_PAT" - script: - - apk add jq curl - - scripts/process_custom_semgrep_results.sh diff --git a/.semgrepignore b/.semgrepignore deleted file mode 100644 index bdd3ac98876..00000000000 --- a/.semgrepignore +++ /dev/null @@ -1,107 +0,0 @@ -*.log -*.swp -*.mo -*.edit.po -*.rej -.dir-locals.el -.DS_Store -.bundle -.chef -.directory -.eslintcache -/.envrc -eslint-report.html -/.gitlab_shell_secret -.idea -.nova -/.vscode/* -/.rbenv-version -.rbx/ -/.ruby-gemset -/.ruby-version -/.tool-versions -/.rvmrc -/.secret -.sass-cache/ -/.vagrant -/.yarn-cache -/.byebug_history -/Vagrantfile -/app/assets/images/icons.json -/app/assets/images/icons.svg -/app/assets/images/illustrations/ -/app/assets/javascripts/locale/**/app.js -/backups/* -/config/aws.yml -/config/cable.yml -/config/database*.yml -/config/gitlab.yml -/config/gitlab_ci.yml -/config/Gitlab.gitlab-license -/config/initializers/smtp_settings.rb -/config/initializers/relative_url.rb -/config/resque.yml -/config/redis.*.yml -/config/unicorn.rb -/config/puma.rb -/config/secrets.yml -/config/sidekiq.yml -/config/registry.key -/coverage/* -/db/*.sqlite3 -/db/*.sqlite3-journal -/db/data.yml -/doc/code/* -/dump.rdb -/jsconfig.json -/lefthook-local.yml -/log/*.log* -/node_modules -/nohup.out -/public/assets/ -/public/uploads.* -/public/uploads/ -/public/sitemap.xml -/public/sitemap.xml.gz -/shared/artifacts/ -/spec/examples.txt -/rails_best_practices_output.html -/tags -/vendor/bundle/* -/vendor/gitaly-ruby -/builds* -/.gitlab_workhorse_secret -/.gitlab_pages_secret -/.gitlab_kas_secret -/webpack-report/ -/crystalball/ -/test_results/ -/deprecations/ -/knapsack/ -/rspec_flaky/ -/rspec/ -/locale/**/LC_MESSAGES -/locale/**/*.time_stamp -/.rspec -/.gitlab_smime_key -/.gitlab_smime_cert -package-lock.json -/junit_*.xml -/coverage-frontend/ -jsdoc/ -**/tmp/rubocop_cache/** -.overcommit.yml -.overcommit.yml.backup -.projections.json -/qa/.rakeTasks -webpack-dev-server.json -/.nvimrc -.solargraph.yml -/tmp/matching_foss_tests.txt -/tmp/matching_tests.txt -ee/changelogs/unreleased-ee -/sitespeed-result -tags.lock -tags.temp -.stylelintcache -.solargraph.yml diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index d62a726d91e..14352baf9ba 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -f099614e635d05483055ba6fbebc74d961bf2ce5 +70d6aa021ebfc05d9d727a7eb4c9ff4782db4c30 diff --git a/app/assets/javascripts/access_tokens/components/new_access_token_app.vue b/app/assets/javascripts/access_tokens/components/new_access_token_app.vue index 69a4fedabae..5aeabcefad5 100644 --- a/app/assets/javascripts/access_tokens/components/new_access_token_app.vue +++ b/app/assets/javascripts/access_tokens/components/new_access_token_app.vue @@ -21,6 +21,7 @@ export default { description: __("Make sure you save it - you won't be able to access it again."), label: __('Your new %{accessTokenType}'), }, + tokenInputId: 'new-access-token', inject: ['accessTokenType'], data() { return { errors: null, infoAlert: null, newToken: null }; @@ -41,6 +42,14 @@ export default { copyButtonTitle() { return sprintf(this.$options.i18n.copyButtonTitle, { accessTokenType: this.accessTokenType }); }, + formInputGroupProps() { + return { + id: this.$options.tokenInputId, + class: 'qa-created-access-token', + 'data-qa-selector': 'created_access_token_field', + name: this.$options.tokenInputId, + }; + }, label() { return sprintf(this.$options.i18n.label, { accessTokenType: this.accessTokenType }); }, @@ -92,16 +101,15 @@ export default {