From 7c0e5472c80f1826b36916a95e6f9d84a7b68fe3 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 9 Sep 2022 18:12:57 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/rails.gitlab-ci.yml | 1 + .gitlab/ci/rules.gitlab-ci.yml | 27 ++-- .../repository/components/blob_controls.vue | 2 +- .../merge_requests/drafts_controller.rb | 12 +- .../settings/integrations_controller.rb | 11 +- .../branch_rules/branch_protection_type.rb | 17 +++ .../types/projects/branch_rule_type.rb | 6 + app/models/notification_recipient.rb | 10 ++ .../merge_requests/mergeability/logger.rb | 103 +++++++++++++ .../mergeability/run_checks_service.rb | 13 +- app/uploaders/object_storage/cdn.rb | 46 ++++++ .../object_storage/cdn/google_cdn.rb | 141 ++++++++++++++++++ .../_account_and_limit.html.haml | 6 +- .../block_emails_with_failures.yml | 8 + .../mergeability_checks_logger.yml | 8 + .../000_inflections.rb | 1 + config/metrics/aggregates/code_review.yml | 4 + ...e_review_submit_review_approve_monthly.yml | 25 ++++ ...e_review_submit_review_comment_monthly.yml | 25 ++++ ...de_review_submit_review_approve_weekly.yml | 25 ++++ ...de_review_submit_review_comment_weekly.yml | 25 ++++ doc/api/graphql/reference/index.md | 11 ++ doc/development/fe_guide/index.md | 3 +- doc/user/permissions.md | 27 ++-- doc/user/tasks.md | 3 - doc/user/usage_quotas.md | 21 +-- lib/gitlab/application_rate_limiter.rb | 3 +- lib/gitlab/gitaly_client/ref_service.rb | 5 +- .../webhook_processors/failure_logger.rb | 7 +- .../usage_data_counters/hll_redis_counter.rb | 1 - .../known_events/code_review_events.yml | 8 + .../known_events/common.yml | 5 - .../known_events/epic_board_events.yml | 19 --- .../merge_request_activity_unique_counter.rb | 10 ++ locale/gitlab.pot | 8 +- qa/qa/resource/base.rb | 22 ++- qa/qa/resource/personal_access_token.rb | 16 +- .../project/project_owner_permissions_spec.rb | 6 +- .../merge_requests/drafts_controller_spec.rb | 24 +++ .../settings/integrations_controller_spec.rb | 8 +- .../user_uses_header_search_field_spec.rb | 1 + spec/fixtures/cdn/google_cloud.json | 17 +++ .../types/branch_protection_type_spec.rb | 13 ++ spec/graphql/types/branch_rule_type_spec.rb | 21 +-- .../gitlab/gitaly_client/ref_service_spec.rb | 16 ++ .../webhook_processors/failure_logger_spec.rb | 47 ++++-- .../hll_redis_counter_spec.rb | 2 - spec/models/namespace_setting_spec.rb | 20 ++- spec/models/notification_recipient_spec.rb | 50 +++++++ spec/models/repository_spec.rb | 27 ++++ .../branch_rules/branch_protection_spec.rb | 60 ++++++++ spec/requests/api/group_export_spec.rb | 1 + spec/requests/api/search_spec.rb | 1 + .../mergeability/logger_spec.rb | 121 +++++++++++++++ .../mergeability/run_checks_service_spec.rb | 10 ++ .../object_storage/cdn/google_cdn_spec.rb | 137 +++++++++++++++++ spec/uploaders/object_storage/cdn_spec.rb | 85 +++++++++++ 57 files changed, 1217 insertions(+), 135 deletions(-) create mode 100644 app/graphql/types/branch_rules/branch_protection_type.rb create mode 100644 app/services/merge_requests/mergeability/logger.rb create mode 100644 app/uploaders/object_storage/cdn.rb create mode 100644 app/uploaders/object_storage/cdn/google_cdn.rb create mode 100644 config/feature_flags/development/block_emails_with_failures.yml create mode 100644 config/feature_flags/development/mergeability_checks_logger.yml create mode 100644 config/metrics/counts_28d/20220627133135_i_code_review_submit_review_approve_monthly.yml create mode 100644 config/metrics/counts_28d/20220627134108_i_code_review_submit_review_comment_monthly.yml create mode 100644 config/metrics/counts_7d/20220627133128_i_code_review_submit_review_approve_weekly.yml create mode 100644 config/metrics/counts_7d/20220627134100_i_code_review_submit_review_comment_weekly.yml delete mode 100644 lib/gitlab/usage_data_counters/known_events/epic_board_events.yml create mode 100644 spec/fixtures/cdn/google_cloud.json create mode 100644 spec/graphql/types/branch_protection_type_spec.rb create mode 100644 spec/requests/api/graphql/project/branch_rules/branch_protection_spec.rb create mode 100644 spec/services/merge_requests/mergeability/logger_spec.rb create mode 100644 spec/uploaders/object_storage/cdn/google_cdn_spec.rb create mode 100644 spec/uploaders/object_storage/cdn_spec.rb diff --git a/.gitlab/ci/rails.gitlab-ci.yml b/.gitlab/ci/rails.gitlab-ci.yml index 5235db776a8..967a7ddf924 100644 --- a/.gitlab/ci/rails.gitlab-ci.yml +++ b/.gitlab/ci/rails.gitlab-ci.yml @@ -167,6 +167,7 @@ setup-test-env: variables: SETUP_DB: "false" script: + - echo $CI_MERGE_REQUEST_APPROVED - source scripts/gitlab_workhorse_component_helpers.sh - run_timed_command "download_and_extract_gitlab_workhorse_package" || true - run_timed_command "scripts/setup-test-env" diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index 754e623c5ad..f4fa94ba859 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -538,6 +538,9 @@ rules: - <<: *if-merge-request-approved when: never + # Temporarily disabled minimal rspec jobs before and after approval because of https://gitlab.com/gitlab-org/gitlab/-/issues/373064. + - <<: *if-merge-request-not-approved + when: never - <<: *if-automated-merge-request when: never - <<: *if-security-merge-request @@ -559,8 +562,6 @@ changes: *backend-patterns - <<: *if-security-merge-request changes: *backend-patterns - - <<: *if-merge-request-not-approved - when: never .rails:rules:as-if-foss-migration-unit-integration:minimal-default-rules: rules: @@ -590,8 +591,6 @@ changes: *code-backstage-patterns - <<: *if-security-merge-request changes: *code-backstage-patterns - - <<: *if-merge-request-not-approved - when: never .rails:rules:system:minimal-default-rules: rules: @@ -725,6 +724,16 @@ ################## # Frontend rules # ################## + +.frontend:rules:minimal-default-rules: + rules: + - <<: *if-merge-request-approved + when: never + - <<: *if-automated-merge-request + when: never + - <<: *if-security-merge-request + when: never + .frontend:rules:compile-production-assets: rules: - <<: *if-not-canonical-namespace @@ -798,7 +807,7 @@ rules: - <<: *if-fork-merge-request changes: *code-backstage-patterns - - !reference [".rails:rules:minimal-default-rules", rules] + - !reference [".frontend:rules:minimal-default-rules", rules] - <<: *if-merge-request-labels-run-all-jest when: never - changes: *core-frontend-patterns @@ -824,7 +833,7 @@ .frontend:rules:jest:minimal:as-if-foss: rules: - !reference [".strict-ee-only-rules", rules] - - !reference [".rails:rules:minimal-default-rules", rules] + - !reference [".frontend:rules:minimal-default-rules", rules] - <<: *if-merge-request-labels-run-all-jest when: never - <<: *if-fork-merge-request @@ -1022,8 +1031,6 @@ changes: *db-patterns - <<: *if-security-merge-request changes: *db-patterns - - <<: *if-merge-request-not-approved - when: never - changes: *db-patterns .rails:rules:ee-and-foss-migration:minimal: @@ -1127,8 +1134,6 @@ changes: *db-patterns - <<: *if-security-merge-request changes: *db-patterns - - <<: *if-merge-request-not-approved - when: never - changes: *db-patterns .rails:rules:ee-only-migration:minimal: @@ -1218,8 +1223,6 @@ changes: *db-patterns - <<: *if-security-merge-request changes: *db-patterns - - <<: *if-merge-request-not-approved - when: never .rails:rules:as-if-foss-migration:minimal: rules: diff --git a/app/assets/javascripts/repository/components/blob_controls.vue b/app/assets/javascripts/repository/components/blob_controls.vue index 3223ed92fe2..fb1227f0df9 100644 --- a/app/assets/javascripts/repository/components/blob_controls.vue +++ b/app/assets/javascripts/repository/components/blob_controls.vue @@ -90,7 +90,7 @@ export default {