Use non cached variables to get scroll position because of the performance bar
This commit is contained in:
parent
889c7081f1
commit
7c636732fb
1 changed files with 14 additions and 10 deletions
|
@ -96,14 +96,14 @@ export default class Job {
|
|||
|
||||
// eslint-disable-next-line class-methods-use-this
|
||||
canScroll() {
|
||||
return this.$document.height() > this.$window.height();
|
||||
return $(document).height() > $(window).height();
|
||||
}
|
||||
|
||||
toggleScroll() {
|
||||
const currentPosition = this.$document.scrollTop();
|
||||
const scrollHeight = this.$document.height();
|
||||
const currentPosition = $(document).scrollTop();
|
||||
const scrollHeight = $(document).height();
|
||||
|
||||
const windowHeight = this.$window.height();
|
||||
const windowHeight = $(window).height();
|
||||
if (this.canScroll()) {
|
||||
if (currentPosition > 0 &&
|
||||
(scrollHeight - currentPosition !== windowHeight)) {
|
||||
|
@ -127,18 +127,22 @@ export default class Job {
|
|||
this.toggleDisableButton(this.$scrollBottomBtn, true);
|
||||
}
|
||||
}
|
||||
|
||||
// eslint-disable-next-line class-methods-use-this
|
||||
isScrolledToBottom() {
|
||||
const currentPosition = this.$document.scrollTop();
|
||||
const scrollHeight = this.$document.height();
|
||||
const $document = $(document);
|
||||
|
||||
const currentPosition = $document.scrollTop();
|
||||
const scrollHeight = $document.height();
|
||||
|
||||
const windowHeight = $(window).height();
|
||||
|
||||
const windowHeight = this.$window.height();
|
||||
return scrollHeight - currentPosition === windowHeight;
|
||||
}
|
||||
|
||||
// eslint-disable-next-line class-methods-use-this
|
||||
scrollDown() {
|
||||
this.$document.scrollTop(this.$document.height());
|
||||
const $document = $(document);
|
||||
$document.scrollTop($document.height());
|
||||
}
|
||||
|
||||
scrollToBottom() {
|
||||
|
@ -148,7 +152,7 @@ export default class Job {
|
|||
}
|
||||
|
||||
scrollToTop() {
|
||||
this.$document.scrollTop(0);
|
||||
$(document).scrollTop(0);
|
||||
this.hasBeenScrolled = true;
|
||||
this.toggleScroll();
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue