kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Perform more redactions in Redis performance bar traces

Browse source 
HMSET and AUTH commands were not properly redacted. This commit
does that and adds a test.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64309
This commit is contained in:
Dietrich Stein 2019-07-18 06:03:29 +00:00 committed by Kushal Pandya
parent 90a188d85d
commit 7c91a466db
5 changed files with 28 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
app/views/projects/pipelines/charts.html.haml
View file

@ -2,12 +2,9 @@
- page_title _('CI / CD Charts')
%div{ class: container_class }
#charts.ci-charts
.row
.col-md-6
= render 'projects/pipelines/charts/overall'
.col-md-6
= render 'projects/pipelines/charts/pipeline_times'
= render 'projects/pipelines/charts/overall'
%hr
= render 'projects/pipelines/charts/pipelines'

21
app/views/projects/pipelines/charts/_overall.haml
View file

@ -1,15 +1,6 @@
%h4= s_("PipelineCharts|Overall statistics")
%ul
%li
= s_("PipelineCharts|Total:")
%strong= n_("1 pipeline", "%d pipelines", @counts[:total]) % @counts[:total]
%li
= s_("PipelineCharts|Successful:")
%strong= n_("1 pipeline", "%d pipelines", @counts[:success]) % @counts[:success]
%li
= s_("PipelineCharts|Failed:")
%strong= n_("1 pipeline", "%d pipelines", @counts[:failed]) % @counts[:failed]
%li
= s_("PipelineCharts|Success ratio:")
%strong
#{success_ratio(@counts)}%
%h4.mt-4.mb-4= s_("PipelineCharts|Overall statistics")
.row
.col-md-6
= render 'projects/pipelines/charts/pipeline_statistics'
.col-md-6
= render 'projects/pipelines/charts/pipeline_times'

14
app/views/projects/pipelines/charts/_pipeline_statistics.haml Normal file
View file

@ -0,0 +1,14 @@
%ul
%li
= s_("PipelineCharts|Total:")
%strong= n_("1 pipeline", "%d pipelines", @counts[:total]) % @counts[:total]
%li
= s_("PipelineCharts|Successful:")
%strong= n_("1 pipeline", "%d pipelines", @counts[:success]) % @counts[:success]
%li
= s_("PipelineCharts|Failed:")
%strong= n_("1 pipeline", "%d pipelines", @counts[:failed]) % @counts[:failed]
%li
= s_("PipelineCharts|Success ratio:")
%strong
#{success_ratio(@counts)}%

2
app/views/projects/pipelines/charts/_pipelines.haml
View file

@ -1,4 +1,4 @@
%h4= _("Pipelines charts")
%h4.mt-4.mb-4= _("Pipelines charts")
%p
 
%span.legend-success

5
changelogs/unreleased/ds-charts-whitespace.yml Normal file
View file

@ -0,0 +1,5 @@
---
title: Improves section header whitespace on the CI/CD Charts page
merge_request: 30531
author:
type: fixed