Perform more redactions in Redis performance bar traces
HMSET and AUTH commands were not properly redacted. This commit does that and adds a test. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64309
This commit is contained in:
parent
90a188d85d
commit
7c91a466db
5 changed files with 28 additions and 21 deletions
|
@ -2,12 +2,9 @@
|
||||||
- page_title _('CI / CD Charts')
|
- page_title _('CI / CD Charts')
|
||||||
|
|
||||||
%div{ class: container_class }
|
%div{ class: container_class }
|
||||||
|
|
||||||
#charts.ci-charts
|
#charts.ci-charts
|
||||||
.row
|
= render 'projects/pipelines/charts/overall'
|
||||||
.col-md-6
|
|
||||||
= render 'projects/pipelines/charts/overall'
|
|
||||||
.col-md-6
|
|
||||||
= render 'projects/pipelines/charts/pipeline_times'
|
|
||||||
|
|
||||||
%hr
|
%hr
|
||||||
= render 'projects/pipelines/charts/pipelines'
|
= render 'projects/pipelines/charts/pipelines'
|
||||||
|
|
|
@ -1,15 +1,6 @@
|
||||||
%h4= s_("PipelineCharts|Overall statistics")
|
%h4.mt-4.mb-4= s_("PipelineCharts|Overall statistics")
|
||||||
%ul
|
.row
|
||||||
%li
|
.col-md-6
|
||||||
= s_("PipelineCharts|Total:")
|
= render 'projects/pipelines/charts/pipeline_statistics'
|
||||||
%strong= n_("1 pipeline", "%d pipelines", @counts[:total]) % @counts[:total]
|
.col-md-6
|
||||||
%li
|
= render 'projects/pipelines/charts/pipeline_times'
|
||||||
= s_("PipelineCharts|Successful:")
|
|
||||||
%strong= n_("1 pipeline", "%d pipelines", @counts[:success]) % @counts[:success]
|
|
||||||
%li
|
|
||||||
= s_("PipelineCharts|Failed:")
|
|
||||||
%strong= n_("1 pipeline", "%d pipelines", @counts[:failed]) % @counts[:failed]
|
|
||||||
%li
|
|
||||||
= s_("PipelineCharts|Success ratio:")
|
|
||||||
%strong
|
|
||||||
#{success_ratio(@counts)}%
|
|
||||||
|
|
|
@ -0,0 +1,14 @@
|
||||||
|
%ul
|
||||||
|
%li
|
||||||
|
= s_("PipelineCharts|Total:")
|
||||||
|
%strong= n_("1 pipeline", "%d pipelines", @counts[:total]) % @counts[:total]
|
||||||
|
%li
|
||||||
|
= s_("PipelineCharts|Successful:")
|
||||||
|
%strong= n_("1 pipeline", "%d pipelines", @counts[:success]) % @counts[:success]
|
||||||
|
%li
|
||||||
|
= s_("PipelineCharts|Failed:")
|
||||||
|
%strong= n_("1 pipeline", "%d pipelines", @counts[:failed]) % @counts[:failed]
|
||||||
|
%li
|
||||||
|
= s_("PipelineCharts|Success ratio:")
|
||||||
|
%strong
|
||||||
|
#{success_ratio(@counts)}%
|
|
@ -1,4 +1,4 @@
|
||||||
%h4= _("Pipelines charts")
|
%h4.mt-4.mb-4= _("Pipelines charts")
|
||||||
%p
|
%p
|
||||||
|
|
||||||
%span.legend-success
|
%span.legend-success
|
||||||
|
|
5
changelogs/unreleased/ds-charts-whitespace.yml
Normal file
5
changelogs/unreleased/ds-charts-whitespace.yml
Normal file
|
@ -0,0 +1,5 @@
|
||||||
|
---
|
||||||
|
title: Improves section header whitespace on the CI/CD Charts page
|
||||||
|
merge_request: 30531
|
||||||
|
author:
|
||||||
|
type: fixed
|
Loading…
Reference in a new issue