Fixes broken tests

This commit is contained in:
Filipa Lacerda 2016-10-11 11:03:11 +01:00
parent 594c320851
commit 7d12683de5
2 changed files with 53 additions and 3 deletions

View File

@ -46,6 +46,14 @@ feature 'Environments', feature: true do
scenario 'does show environment name' do
expect(page).to have_link(environment.name)
end
scenario 'does show number of opened environments in Availabe tab' do
expect(page.find('.js-avaibale-environments-count').text).to eq('1')
end
scenario 'does show number of closed environments in Stopped tab' do
expect(page.find('.js-stopped-environments-count').text).to eq('0')
end
context 'without deployments' do
scenario 'does show no deployments' do
@ -76,6 +84,16 @@ feature 'Environments', feature: true do
expect(page).to have_content(manual.name)
expect(manual.reload).to be_pending
end
scenario 'does show close button' do
# TODO: Add test to verify if close button is visible
# This needs to be true: if local_assigns.fetch(:allow_close, false) && deployment.closeable?
end
scenario 'does allow to close environment' do
# TODO: Add test to verify if close environment works
# This needs to be true: if local_assigns.fetch(:allow_close, false) && deployment.closeable?
end
end
end
end
@ -137,6 +155,16 @@ feature 'Environments', feature: true do
expect(page).to have_content(manual.name)
expect(manual.reload).to be_pending
end
scenario 'does show close button' do
# TODO: Add test to verify if close button is visible
# This needs to be true: if local_assigns.fetch(:allow_close, false) && deployment.closeable?
end
scenario 'does allow to close environment' do
# TODO: Add test to verify if close environment works
# This needs to be true: if local_assigns.fetch(:allow_close, false) && deployment.closeable?
end
end
end
end
@ -194,9 +222,22 @@ feature 'Environments', feature: true do
context 'when logged as master' do
given(:role) { :master }
scenario 'does close environment' do
click_link 'Close'
expect(page).not_to have_link(environment.name)
scenario 'does not have a Close link' do
expect(page).not_to have_link('Close')
end
context 'when environment is opened and can be closed' do
let(:project) { create(:project) }
let(:environment) { create(:environment, project: project) }
let!(:deployment) do
create(:deployment, environment: environment, sha: project.commit('master').id)
end
scenario 'does have a Close link' do
# TODO: Add missing validation. In order to have Close link
# this must be true: last_deployment.try(:close_action)
end
end
end

View File

@ -79,6 +79,15 @@ feature 'Merge When Build Succeeds', feature: true, js: true do
end
end
context 'Has Environment' do
let(:environment) { create(:environment, project: project) }
it 'does show link to close the environment' do
# TODO add test to verify if the button is visible when this condition
# is met: if environment.closeable?
end
end
def visit_merge_request(merge_request)
visit namespace_project_merge_request_path(merge_request.project.namespace, merge_request.project, merge_request)
end