From 63d8270eb5f6ce2f42495c5a23967509a7f038cf Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Wed, 28 Sep 2016 15:02:01 +0300 Subject: [PATCH 1/2] Fix duplicate master entries in the mr versions dropdown Signed-off-by: Dmitriy Zaporozhets --- .../projects/merge_requests/show/_versions.html.haml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/views/projects/merge_requests/show/_versions.html.haml b/app/views/projects/merge_requests/show/_versions.html.haml index 49819519759..904452fcc4f 100644 --- a/app/views/projects/merge_requests/show/_versions.html.haml +++ b/app/views/projects/merge_requests/show/_versions.html.haml @@ -58,11 +58,11 @@ .monospace #{short_sha(merge_request_diff.head_commit_sha)} %small = time_ago_with_tooltip(merge_request_diff.created_at) - %li - = link_to merge_request_version_path(@project, @merge_request, @merge_request_diff), class: ('is-active' unless @start_sha) do - %strong - #{@merge_request.target_branch} (base) - .monospace #{short_sha(@merge_request_diff.base_commit_sha)} + %li + = link_to merge_request_version_path(@project, @merge_request, @merge_request_diff), class: ('is-active' unless @start_sha) do + %strong + #{@merge_request.target_branch} (base) + .monospace #{short_sha(@merge_request_diff.base_commit_sha)} - unless @merge_request_diff.latest? && !@start_sha .comments-disabled-notif.content-block From d238ff2657c8c9a76353367c672e3d592188c42e Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Wed, 28 Sep 2016 15:09:23 +0300 Subject: [PATCH 2/2] Add changelog for duplicate branch bug in mr version feature Signed-off-by: Dmitriy Zaporozhets --- CHANGELOG | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG b/CHANGELOG index 8e75ef4214b..a1fc9054a2a 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -21,6 +21,7 @@ v 8.12.2 (unreleased) - Fix an issue with the "Commits" section of the cycle analytics summary. !6513 - Fix errors importing project feature and milestone models using GitLab project import - Make JWT messages Docker-compatible + - Fix duplicate branch entry in the merge request version compare dropdown v 8.12.1 - Fix a memory leak in HTML::Pipeline::SanitizationFilter::WHITELIST