Check whether new service created from template is valid after unflagging it as a template
This commit is contained in:
parent
3f784d8f34
commit
7e34a19f29
2 changed files with 2 additions and 2 deletions
|
@ -281,9 +281,9 @@ class Service < ActiveRecord::Base
|
|||
|
||||
def self.build_from_template(project_id, template)
|
||||
service = template.dup
|
||||
service.active = false unless service.valid?
|
||||
service.template = false
|
||||
service.project_id = project_id
|
||||
service.active = false if service.active? && !service.valid?
|
||||
service
|
||||
end
|
||||
|
||||
|
|
|
@ -78,7 +78,7 @@ describe Service do
|
|||
context 'when template is invalid' do
|
||||
it 'sets service template to inactive when template is invalid' do
|
||||
project = create(:project)
|
||||
template = JiraService.new(template: true, active: true)
|
||||
template = KubernetesService.new(template: true, active: true)
|
||||
template.save(validate: false)
|
||||
|
||||
service = described_class.build_from_template(project.id, template)
|
||||
|
|
Loading…
Reference in a new issue