kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Move Profile groups tests to Dashboard group tests

Browse source
This commit is contained in:
Dmitriy Zaporozhets 2015-03-08 20:52:22 -07:00
parent 9b3e156e43
commit 7e4258777f
5 changed files with 73 additions and 76 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
features/profile/group.feature → features/dashboard/group.feature
View file

@ -1,4 +1,4 @@
@profile
@dashboard
Feature: Profile Group
Background:
Given I sign in as "John Doe"
@ -10,18 +10,18 @@ Feature: Profile Group
@javascript
Scenario: Owner should be able to leave from group if he is not the last owner
Given "Mary Jane" is owner of group "Owned"
When I visit profile groups page
When I visit dashboard groups page
Then I should see group "Owned" in group list
Then I should see group "Guest" in group list
When I click on the "Leave" button for group "Owned"
And I visit profile groups page
And I visit dashboard groups page
Then I should not see group "Owned" in group list
Then I should see group "Guest" in group list
@javascript
Scenario: Owner should not be able to leave from group if he is the last owner
Given "Mary Jane" is guest of group "Owned"
When I visit profile groups page
When I visit dashboard groups page
Then I should see group "Owned" in group list
Then I should see group "Guest" in group list
Then I should not see the "Leave" button for group "Owned"
@ -29,20 +29,20 @@ Feature: Profile Group
@javascript
Scenario: Guest should be able to leave from group
Given "Mary Jane" is guest of group "Guest"
When I visit profile groups page
When I visit dashboard groups page
Then I should see group "Owned" in group list
Then I should see group "Guest" in group list
When I click on the "Leave" button for group "Guest"
When I visit profile groups page
When I visit dashboard groups page
Then I should see group "Owned" in group list
Then I should not see group "Guest" in group list
@javascript
Scenario: Guest should be able to leave from group even if he is the only user in the group
When I visit profile groups page
When I visit dashboard groups page
Then I should see group "Owned" in group list
Then I should see group "Guest" in group list
When I click on the "Leave" button for group "Guest"
When I visit profile groups page
When I visit dashboard groups page
Then I should see group "Owned" in group list
Then I should not see group "Guest" in group list

2
features/steps/profile/group.rb → features/steps/dashboard/group.rb
View file

@ -1,4 +1,4 @@
class Spinach::Features::ProfileGroup < Spinach::FeatureSteps
class Spinach::Features::DashboardGroup < Spinach::FeatureSteps
include SharedAuthentication
include SharedGroup
include SharedPaths

16
features/steps/shared/paths.rb
View file

@ -87,6 +87,14 @@ module SharedPaths
visit help_path
end
step 'I visit dashboard groups page' do
visit dashboard_groups_path
end
step 'I should be redirected to the dashboard groups page' do
current_path.should == dashboard_groups_path
end
# ----------------------------------------
# Profile
# ----------------------------------------
@ -119,14 +127,6 @@ module SharedPaths
visit history_profile_path
end
step 'I visit profile groups page' do
visit profile_groups_path
end
step 'I should be redirected to the profile groups page' do
current_path.should == profile_groups_path
end
# ----------------------------------------
# Admin
# ----------------------------------------

8
spec/features/security/dashboard_access_spec.rb
View file

@ -52,4 +52,12 @@ describe "Dashboard access", feature: true do
it { expect(new_group_path).to be_allowed_for :user }
it { expect(new_group_path).to be_denied_for :visitor }
end
describe "GET /profile/groups" do
subject { dashboard_groups_path }
it { is_expected.to be_allowed_for :admin }
it { is_expected.to be_allowed_for :user }
it { is_expected.to be_denied_for :visitor }
end
end

13
spec/features/security/profile_access_spec.rb
View file

@ -1,7 +1,6 @@
require 'spec_helper'
describe "Users Security", feature: true do
describe "Project" do
describe "Profile access", feature: true do
before do
@u1 = create(:user)
end
@ -63,14 +62,4 @@ describe "Users Security", feature: true do
it { is_expected.to be_allowed_for :user }
it { is_expected.to be_denied_for :visitor }
end
describe "GET /profile/groups" do
subject { profile_groups_path }
it { is_expected.to be_allowed_for @u1 }
it { is_expected.to be_allowed_for :admin }
it { is_expected.to be_allowed_for :user }
it { is_expected.to be_denied_for :visitor }
end
end
end