kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Do not return false in commit status transition

This commit is contained in:
Grzegorz Bizon 2016-10-04 16:34:22 +02:00
parent 4e4640b10b
commit 7f270d041d
3 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/commit_status.rb
View File

@ -71,7 +71,7 @@ class CommitStatus < ActiveRecord::Base
after_transition do |commit_status, transition|
commit_status.pipeline.try do |pipeline|
return false if transition.loopback?
break if transition.loopback?
if commit_status.complete?
ProcessPipelineWorker.perform_async(pipeline.id)

5
app/workers/process_pipeline_worker.rb
View File

@ -4,8 +4,7 @@ class ProcessPipelineWorker
sidekiq_options queue: :default
def perform(pipeline_id)
Ci::Pipeline.find_by(id: pipeline_id).try do |pipeline|
pipeline.process!
end
Ci::Pipeline.find_by(id: pipeline_id)
.try(:process!)
end
end

5
app/workers/update_pipeline_worker.rb
View File

@ -4,8 +4,7 @@ class UpdatePipelineWorker
sidekiq_options queue: :default
def perform(pipeline_id)
Ci::Pipeline.find_by(id: pipeline_id).try do |pipeline|
pipeline.update_status
end
Ci::Pipeline.find_by(id: pipeline_id)
.try(:update_status)
end
end