kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Merge branch 'rails5-exists-query' into 'master' 

Replace `.exists` with `EXISTS ()`

Closes #46277

See merge request gitlab-org/gitlab-ce!19178
This commit is contained in:
Yorick Peterse 2018-05-31 11:22:34 +00:00
parent 3f6fffe952 1d766bfbdf
commit 7f32b9d7b5
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/services/boards/issues/list_service.rb
View File

@ -63,7 +63,7 @@ module Boards
def without_board_labels(issues)
return issues unless board_label_ids.any?
issues.where.not(issues_label_links.limit(1).arel.exists)
issues.where.not('EXISTS (?)', issues_label_links.limit(1))
end
def issues_label_links
@ -71,10 +71,8 @@ module Boards
end
def with_list_label(issues)
issues.where(
LabelLink.where("label_links.target_type = 'Issue' AND label_links.target_id = issues.id")
.where("label_links.label_id = ?", list.label_id).limit(1).arel.exists
)
issues.where('EXISTS (?)', LabelLink.where("label_links.target_type = 'Issue' AND label_links.target_id = issues.id")
.where("label_links.label_id = ?", list.label_id).limit(1))
end
end
end