diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index 3827fff079c..7f469221da2 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -164,7 +164,7 @@ - "vendor/assets/**/*" - ".gitlab/ci/**/*" - ".{eslintignore,gitattributes,nvmrc,prettierrc,stylelintrc,yamllint}" - - ".{codeclimate,eslintrc,gitlab-ci,haml-lint,haml-lint_todo,rubocop,rubocop_todo,scss-lint}.yml" + - ".{codeclimate,eslintrc,gitlab-ci,haml-lint,haml-lint_todo,rubocop,rubocop_todo,rubocop_manual_todo,scss-lint}.yml" - "*_VERSION" - "Gemfile{,.lock}" - "Rakefile" @@ -186,7 +186,7 @@ - "vendor/assets/**/*" - ".gitlab/ci/**/*" - ".{eslintignore,gitattributes,nvmrc,prettierrc,stylelintrc,yamllint}" - - ".{codeclimate,eslintrc,gitlab-ci,haml-lint,haml-lint_todo,rubocop,rubocop_todo,scss-lint}.yml" + - ".{codeclimate,eslintrc,gitlab-ci,haml-lint,haml-lint_todo,rubocop,rubocop_todo,rubocop_manual_todo,scss-lint}.yml" - "*_VERSION" - "Gemfile{,.lock}" - "Rakefile" @@ -210,7 +210,7 @@ - "vendor/assets/**/*" - ".gitlab/ci/**/*" - ".{eslintignore,gitattributes,nvmrc,prettierrc,stylelintrc,yamllint}" - - ".{codeclimate,eslintrc,gitlab-ci,haml-lint,haml-lint_todo,rubocop,rubocop_todo,scss-lint}.yml" + - ".{codeclimate,eslintrc,gitlab-ci,haml-lint,haml-lint_todo,rubocop,rubocop_todo,rubocop_manual_todo,scss-lint}.yml" - "*_VERSION" - "Gemfile{,.lock}" - "Rakefile" @@ -231,7 +231,7 @@ - "vendor/assets/**/*" - ".gitlab/ci/**/*" - ".{eslintignore,gitattributes,nvmrc,prettierrc,stylelintrc,yamllint}" - - ".{codeclimate,eslintrc,gitlab-ci,haml-lint,haml-lint_todo,rubocop,rubocop_todo,scss-lint}.yml" + - ".{codeclimate,eslintrc,gitlab-ci,haml-lint,haml-lint_todo,rubocop,rubocop_todo,rubocop_manual_todo,scss-lint}.yml" - "*_VERSION" - "Gemfile{,.lock}" - "Rakefile" diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index 3fe46000e5e..330c7906895 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -43,8 +43,6 @@ Graphql/IDType: Graphql/ResolverType: Exclude: - - 'app/graphql/resolvers/assigned_merge_requests_resolver.rb' - - 'app/graphql/resolvers/authored_merge_requests_resolver.rb' - 'app/graphql/resolvers/base_resolver.rb' - 'app/graphql/resolvers/ci/pipeline_stages_resolver.rb' - 'app/graphql/resolvers/commit_pipelines_resolver.rb' @@ -61,7 +59,6 @@ Graphql/ResolverType: - 'app/graphql/resolvers/project_pipelines_resolver.rb' - 'app/graphql/resolvers/projects/snippets_resolver.rb' - 'app/graphql/resolvers/snippets_resolver.rb' - - 'app/graphql/resolvers/user_merge_requests_resolver.rb' - 'app/graphql/resolvers/users/group_count_resolver.rb' - 'app/graphql/resolvers/users/snippets_resolver.rb' - 'ee/app/graphql/resolvers/ci/jobs_resolver.rb' diff --git a/GITLAB_WORKHORSE_VERSION b/GITLAB_WORKHORSE_VERSION index d9b7ec5a2f7..a99caf2cdef 100644 --- a/GITLAB_WORKHORSE_VERSION +++ b/GITLAB_WORKHORSE_VERSION @@ -1 +1 @@ -8.53.0 +8.54.0 diff --git a/app/assets/javascripts/issuable_list/components/issuable_item.vue b/app/assets/javascripts/issuable_list/components/issuable_item.vue index 05bc3185cc8..1ee794ab208 100644 --- a/app/assets/javascripts/issuable_list/components/issuable_item.vue +++ b/app/assets/javascripts/issuable_list/components/issuable_item.vue @@ -84,6 +84,14 @@ export default { } return {}; }, + showDiscussions() { + return typeof this.issuable.userDiscussionsCount === 'number'; + }, + showIssuableMeta() { + return Boolean( + this.hasSlotContents('status') || this.showDiscussions || this.issuable.assignees, + ); + }, }, methods: { hasSlotContents(slotName) { @@ -166,6 +174,7 @@ export default { {{ author.name }} +  
-