Refactor to use updated params in finder

This commit is contained in:
Heinrich Lee Yu 2018-11-19 19:59:08 +08:00
parent 263849f6c2
commit 801fc90c12
2 changed files with 4 additions and 15 deletions

View File

@ -188,21 +188,6 @@ module ApplicationHelper
"#{request.path}?#{params.to_param}"
end
def filter_bar_params
{
milestone_title: params[:milestone_title],
assignee_id: params[:assignee_id],
author_id: params[:author_id],
search: params[:search],
label_name: params[:label_name],
my_reaction_emoji: params[:my_reaction_emoji]
}
end
def has_filter_bar_param?
filter_bar_params.values.any? { |v| v.present? }
end
def outdated_browser?
browser.ie? && browser.version.to_i < 10
end

View File

@ -362,6 +362,10 @@ module IssuablesHelper
end
end
def has_filter_bar_param?
finder.class.scalar_params.any? { |p| params[p].present? }
end
private
def sidebar_gutter_collapsed?